Contrib.social

Automated Drupal 11 compatibility fixes for media_migration

Open on Drupal.org →
Created on 18 March 2024, 10 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Needs review

Version

1.0

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @project update bot
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.2 & MySQL 8
    last update 10 months ago
    Composer require-dev failure
  • Comment 10 months ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

    Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

    Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug info

    Bot run #11-121090

    This patch was created using these packages:

    1. drupal/upgrade_status: 4.1.0
    2. mglaman/phpstan-drupal: 1.2.7
    3. palantirnet/drupal-rector: 0.20.1
  • Merge request !9Automated Project Update Bot fixes → (Open) created by project update bot
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.2 & MySQL 8
    last update 10 months ago
    Composer require-dev failure
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.2 & MySQL 8
    last update 9 months ago
    Composer require-dev failure
  • Comment 9 months ago →
    project update bot

    This comment was forced and has ignored the check if a change was already posted. This is only done when we want to update the issue without waiting for changes to happen.

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

    Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

    Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

    The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-137198

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.1.0
    2. mglaman/phpstan-drupal: 1.2.10
    3. palantirnet/drupal-rector: 0.20.1
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.2 & MySQL 8
    last update 9 months ago
    Composer require-dev failure
  • Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.2 & MySQL 8
    34:03
    34:03
    Queueing
  • Comment 7 months ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

    Currently Drupal Rector, version 0.20.3, cannot fix all Drupal 11 compatibility problems.

    Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

    The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-199781

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.3.2
    2. mglaman/phpstan-drupal: 1.2.11
    3. palantirnet/drupal-rector: 0.20.3
  • Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.2 & MySQL 8
    33:51
    33:51
    Queueing
  • Comment 30 days ago →
    🇩🇪Germany Anybody Porta Westfalica

    Drupal 11 is out and compatibility is important!

  • Comment 30 days ago →
    🇩🇪Germany Grevil

    grevil → changed the visibility of the branch project-update-bot-only to hidden.

  • Merge request !11Issue #3431903: Automated Drupal 11 compatibility fixes for media_migration → (Open) created by Grevil
  • Comment 30 days ago →
    🇩🇪Germany Grevil

    Unsure, how the backwards compatibility should be handled inside this, as it isn't a "normal" module. This simple version fix should be all we need to make the module functional again.

    To bring the Tests up to D11 standards, we still need to apply (and adjust) the test changes from https://www.drupal.org/files/issues/2024-06-18/media_migration.1.x-dev.r... → and adjust the "StringInputStream" calls, if we want to remove D8/D9 compatibility:

    Instantiation of deprecated class
    Masterminds\HTML5\Parser\StringInputStream: since 2.4, to
    remove in 3.0. Use a string in the scanner instead.

    Otherwise, the attached patch, will make it D11 ready.

  • Comment 30 days ago →
    🇩🇪Germany Grevil
  • Comment 30 days ago →
    🇩🇪Germany Grevil
  • Comment 30 days ago →
    🇩🇪Germany Anybody Porta Westfalica

    Ok let's first fix this simple and then prepare a 2.x branch in a separate issue. Currently this block D11 upgrades!

    RTBC for the simple solution.

  • First commit to issue fork.
  • Comment 30 days ago →
    heddn Nicaragua

    Tests are failing. Back to NW.

  • First commit to issue fork.
  • Pipeline finished with Failed
    27 days ago
    Total: 142s
    #366124
  • Pipeline finished with Failed
    27 days ago
    Total: 162s
    #366128
  • Comment 27 days ago →
    🇺🇸United States joegraduate Arizona, USA

    Remaining GitLab CI composer test failure is blocked by the require-dev dependency on drupal/entity_embed not having a D11 compatible release yet.

  • Comment 23 days ago →
    🇩🇪Germany Anybody Porta Westfalica

    📌 Automated Drupal 10 compatibility fixes Needs review rector adds a trait to the tests, should we copy that over and close the D10 issue already?

  • Comment 23 days ago →
    heddn Nicaragua

    This is mostly postponed on getting entity_embed compatible. But while we are waiting for that, there are still some obvious failures, both in phpstan and in the unit tests that should be rectified to help keep this moving. We should investigate if we move to the new version of Masterminds\HTML5\Parser\StringInputStream and what version of that we should support. Secondly, we should fix FileEntitySourceFieldInstanceTest and any other failures of similar nature.

  • Comment 22 days ago →
    🇩🇪Germany Anybody Porta Westfalica

    @heddn: See 🐛 Drupal 7 to Drupal 11 migration runs forever Active for a major issue in D11 - could you maybe review that one?

    Please decide, if we should incorporate these changes here or keep them separate. Afterwards indeed we should fix the tests, as written above.

  • Comment 22 days ago →
    heddn Nicaragua

    Let's keep those issues separate for the time being.

  • Comment 20 days ago →
    🇩🇪Germany Grevil

    🐛 Drupal 7 to Drupal 11 migration runs forever Active isn't finished yet anyway and the current MR there, doesn't solve that issue as explained in the comments.

  • Comment 19 days ago →
    🇩🇪Germany Grevil

    This should be it. Let's wait for entity_embed to get official D11 compatibility.

  • Pipeline finished with Failed
    19 days ago
    Total: 3693s
    #374689
  • Comment 19 days ago →
    🇩🇪Germany Anybody Porta Westfalica

    Thanks for the fixes @grevil! Hopefully entity_embed will become D11 compatible soon...

  • Comment 19 days ago →
    🇩🇪Germany Grevil

    HA, no way. We actually run into 🐛 Drupal 7 to Drupal 11 migration runs forever Active through the tests now!

    ERROR: Job failed: execution took longer than 1h0m0s seconds

    @heddn, so it actually makes sense now, to merge 🐛 Drupal 7 to Drupal 11 migration runs forever Active and this issue!

  • Comment 19 days ago →
    🇩🇪Germany Anybody Porta Westfalica

    @heddn, so it actually makes sense now, to merge #3494209: Drupal 7 to Drupal 11 migration runs forever and this issue!

    Merge now and proceed here also fixing that issue? (To simplify testng).

    Important note is: The other issue is still unsolved and we have not found the root cause yet.

    Leaving for @heddn to decide how to proceed. We could also copy the D11 changes from here over to the other issue for now to keep them separate for now...

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024