- Issue created by @musa.thomas
- Merge request !99Issue #3460758: [DSFR 1.11.1] Add class on accordion group → (Open) created by musa.thomas
- Issue was unassigned.
- Status changed to Needs review
9 months ago 8:29am 11 July 2024 - 🇫🇷France musa.thomas France 🇫🇷
I'm not sure to understand well the backlog, do we need to set to false if it's accordion group or not
- Status changed to Postponed: needs info
9 months ago 8:49am 11 July 2024 - 🇫🇷France pdureau Paris
Do we really need to add .
setAttribute('data-fr-group', 'false')
in the template, or is it something managed by the JavaScript ?The upstream issue is not clear about this change: https://github.com/GouvernementFR/dsfr/pull/860/files
And the up-to-date documentation is silent about this: https://www.systeme-de-design.gouv.fr/composants-et-modeles/composants/a...I would prefer to do nothing instead of introducing a change we don't understand. What do you think?
- 🇫🇷France musa.thomas France 🇫🇷
hello I did a test
"name": "npm-asset/gouvfr--dsfr", "version": "1.11.2",
The markup seems have not this attributes group or not grouped accordion
- Merge request !112Issue #3460758 by Musa.thomas: DSFR 1.11: Add 'grouped' attribute to accordion group → (Merged) created by spryah
- 🇫🇷France pdureau Paris
I prefer Sorya proposal because we can chose if grouped or not.
Also, we can replace:
{% for accordion in accordions %} {{ accordion }} {% endfor %}
by :
{{ accordions }}