- Issue created by @svendecabooter
- 🇮🇳India anjaliprasannan
anjaliprasannan → changed the visibility of the branch 3524435-add-token-usage to hidden.
- @anjaliprasannan opened merge request.
- 🇧🇪Belgium svendecabooter Gent
@anjaliprasannan shouldn't the MR be against 1.1.x branch?
Not sure what the branching strategy for AI is exactly, but seems to me active dev is against 1.1.x now. - 🇮🇳India anjaliprasannan
Please review the fix and suggest if further changes are required.
- @svendecabooter opened merge request.
- 🇧🇪Belgium svendecabooter Gent
Created 2nd branch with same commit - branched from 1.1.x - since I needed that for my testing purposes.
- 🇮🇳India anjaliprasannan
@svendecabooter Changed the target branch and updated the code.
- 🇧🇪Belgium svendecabooter Gent
svendecabooter → changed the visibility of the branch 3526978-add-providerid-context-1.1.x to hidden.
- 🇧🇪Belgium svendecabooter Gent
As per conversation in #ai on Slack, moving this to 1.2.x branch, since it's a new / extra feature.
- 🇩🇪Germany marcus_johansson
@svendecabooter - added two suggestions, approve them or argue against them and I'll merge.
- First commit to issue fork.
- 🇮🇳India JatinGupta40
As per the suggestion from @marcus_johansson, i have replaced explicit docblock with {@inheritdoc} to avoid duplication, as the method is already documented in the interface.
Thanks.
- 🇩🇪Germany marcus_johansson
Merged with 1.2.x - thanks everybody.
This is an actual breaking change, but I can't think that anyone has extended the event. The other option creates very ugly code.