Contrib.social

Default recipe logo does not meet Project Browser logo requirements

Open on Drupal.org →
Created on 17 December 2024, 5 months ago

Problem/Motivation

I noticed the /images/recipe-logo.png default logo is 4167x3001 pixels, and 153KB.

Sure, it only needs to load once and will be cached by the browser, but it's taking more bandwidth to download, and more CPU cycles to rescale than needed. It's also the wrong shape.

Steps to reproduce

Open the recipes tab, and use the browser "inspect" function to verify the image size of the recipe default logo.

Proposed resolution

  1. Prepare new images in PNG and SVG formats
  2. Review both versions of the image
  3. Consider whether to switch the image to a SVG, for consistency with modules, smaller file size, and greater scalability
  4. Replace current image with chosen one
  5. If switching format, update image path in plugin
🐛 Bug report
Status

Active

Version

2.0

Component

Code

Created by

🇮🇪Ireland lostcarpark

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @lostcarpark
  • Comment 5 months ago →
    🇮🇪Ireland lostcarpark

    I have uploaded PNG and SVG versions of the logo, both sized to 512x512 pixels.

    Here's a preview of the PNG. I had to give the SVG a .TXT extension, so I don't think I can embed here. However they should both look the same unless you zoom in.

    In terms of file size, the PNG is 9KB, while the SVG is 5KB. Both are under the Project Browser requirement of 10KB.

    I would favour using the SVG since it's smaller, and we already use a SVG for the module default image.

  • Comment 5 months ago →
    🇮🇪Ireland lostcarpark

    I've done some optimisation of the SVG file, and got it down to 2.5KB.

  • Merge request !652Resolve #3494655 "Default recipe logo" → (Open) created by lostcarpark
  • Pipeline finished with Failed
    5 months ago
    Total: 1176s
    #374451
  • Pipeline finished with Failed
    5 months ago
    Total: 458s
    #374465
  • Pipeline finished with Failed
    5 months ago
    Total: 403s
    #374676
  • Status changed to Needs review 16 days ago
  • Comment 16 days ago →
    🇮🇳India BhumikaVarshney Delhi

    Hi
    I took pull from the MR and everything is working fine
    Now instead of using png you have replaced it with svg if sometime we zoom in zoom out the svg is looking perfect.
    I have added screenshot of the zoomin svg

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024