Delhi
Account created on 12 February 2019, about 6 years ago
#

Merge Requests

More

Recent comments

🇮🇳India BhumikaVarshney Delhi

Hi
I took pull from the MR and everything is working fine
Now instead of using png you have replaced it with svg if sometime we zoom in zoom out the svg is looking perfect.
I have added screenshot of the zoomin svg

🇮🇳India BhumikaVarshney Delhi

bhumikavarshney made their first commit to this issue’s fork.

🇮🇳India BhumikaVarshney Delhi

Hi
You can structure the custom code component like this:

<div {{ attributes }} class="mycode">
  <div>
    <button>{{ cta }}</button>
  </div>
</div>

must target elements within the component using the wrapper class. This way, the styles won’t bleed into the rest of the page.
Something like this in the screenshot

🇮🇳India BhumikaVarshney Delhi

Hi
I tried to reporduce the issue but not able to reporcude the same.
I edited the button and followed the steps added above.
But in preview i can see the same text which we added.
please refer the screenshots

🇮🇳India BhumikaVarshney Delhi

Hi Kiran
Revise the folder organization by establishing a config folder and placing the install folder within it - This is done

🇮🇳India BhumikaVarshney Delhi

Theming of this component is working as expected
Adding screenshot for the same.

🇮🇳India BhumikaVarshney Delhi

Theming of this component is working as expected
Adding screenshot for the same.

🇮🇳India BhumikaVarshney Delhi

Theming of this component is working as expected
Adding screenshot for the same.

🇮🇳India BhumikaVarshney Delhi

Component is working as expected.
Added screenshot for the same

🇮🇳India BhumikaVarshney Delhi

Issue is resolved now all the components are working fine with the images in preview as well

🇮🇳India BhumikaVarshney Delhi

Theming of this component is working as expected.
Added screenshot for the same

🇮🇳India BhumikaVarshney Delhi

Hi Kiran,
All the changes are done and MR is also merged

🇮🇳India BhumikaVarshney Delhi

The above issue is resolved now
Installation of the theme is working fine

🇮🇳India BhumikaVarshney Delhi

Theming is working as expected.
Screenshot is added.

🇮🇳India BhumikaVarshney Delhi

MR is merged
I have verified this issue and i can see only components which are completed in the list.

🇮🇳India BhumikaVarshney Delhi

Hi Kiran,
Changes are changes are done as per your suggestion.

🇮🇳India BhumikaVarshney Delhi

bhumikavarshney changed the visibility of the branch 3516909-#5-theming-of-frontpage to hidden.

🇮🇳India BhumikaVarshney Delhi

The issue mentioned that svg image code drupal/core/themes/claro/templates/admin/indentation.html.twig added in this template need to be moved to image folder.

But this merge request https://git.drupalcode.org/project/drupal/-/merge_requests/8672/diffs?co... added the same svg by pseudo element.

So need more information do we need to include svg from img tag by using the image source in the url.

As you can refer the
Proposed resolution
Remove the svg tag code from the drupal/core/themes/claro/templates/admin/indentation.html.twig file and create a new svg file in the images folder.

🇮🇳India BhumikaVarshney Delhi

Hi @kopeboy
Can you please more details and any other steps to reproduce this steps Problem/Motivation by this am not able to understand the issue.
It will be really helpful if you add before screenshot or any video.
Thank you

🇮🇳India BhumikaVarshney Delhi

Removed @nest from Claro's form--managed-file stylesheet. Kindly review it.
Thank you!

🇮🇳India BhumikaVarshney Delhi

Removed @nest from Claro's card stylesheet. Please review it.
Thank you!

🇮🇳India BhumikaVarshney Delhi

BhumikaVarshney made their first commit to this issue’s fork.

🇮🇳India BhumikaVarshney Delhi

Hi @acret_seth,
From the merge request #7 the layout issue mentioned in the summary is getting resolved.
please refer the screenshot after taking pull.
Thanks

🇮🇳India BhumikaVarshney Delhi

Hello @Arantxio,
Patch #33 applied successfully,The patch work properly.
please refer to screenshots.

🇮🇳India BhumikaVarshney Delhi

Hi saschaeggi,
I tried to reproduce this issue with Drupal 11.x version but as per the steps mentioned to
Install Module builder
But this module is not compatible with this version adding screenshot for the same.
Can we check this with d10 version or anything am missing on my end.
Thank you!

🇮🇳India BhumikaVarshney Delhi

Working on this issue as a part of Claro Contribution Day.

🇮🇳India BhumikaVarshney Delhi

Hi droplet,
As smustgrave mentioned can you please suggest where we need to use italics font or do we need to remove for the help text added for the field or we need to do it for language specific so accordingly we can do the changes.
Thank You!

🇮🇳India BhumikaVarshney Delhi

BhumikaVarshney changed the visibility of the branch 3374460-add-menu-animations to active.

🇮🇳India BhumikaVarshney Delhi

Hi,
Yes, we can add all the same attributes in views-view-fields.html.twig .
Please refer screenshot for the same.
Hope this will help.
Thanks!

🇮🇳India BhumikaVarshney Delhi

Hi @tinto
What I have noticed after following all your steps and the concern of this issue is that the parent link is not visible.
The issue is not because menus have parent items have the same link the parent link is not visible because the "Initial visibility level" is set to 3 as per your steps.
If we set the initial visibility to the 3rd level the menu will automatically render the 3rd child directly.
I hope this will resolve your issue if I set the "Initial visibility level" to 1 the parent menu is visible.
Please refer to the screenshot.
Thank you!

🇮🇳India BhumikaVarshney Delhi

As per comment #13, I followed the same steps added for the specific case to reproduce the same.

Created 2 menus

Home
-- home 1
Home 3
--home 4

Home menu -> Checked Show as expanded
Home 3 -> unchecked Show as expanded

For my menu block, I have configured it to show 2 levels to display and I have left the expand all menu links unchecked.

So after all this configuration, Second Menu is not expanded as expected in the feature request without applying any patch.
I have attached the screenshot for all the configurations.

Thank You!

Production build 0.71.5 2024