Menu item checkbox "Show as expanded" not working properly

I'd like to see this issue reopened. I don't believe the original issue was solved in that, while the system may work as designed, it does not work as desired. The problem is that, the way it works now, menu option appears expanded when it is the currently selected item even if you have unchecked the "show as expanded" option in the menu link configuration. This is true even if in your menu block configuration you have unchecked the "expand all menu options" option. The only way to keep the selected menu option from showing as expanded is to restrict the menu levels. This makes it impossible to have a menu where you want one option to expand but another option to not expand.

Here is my specific case:

I have a main menu. Two of the options in the main menu have child menu options. I want one to expand and the other to not expand. In the menu configuration, I checked "show as expanded" for the first menu option and left this unchecked for the second menu option.

For my menu block, I have configured it to show 2 levels to display and I have left the expand all menu links unchecked.

The result is that everything works fine except when the second menu option is the select menu option. In that case, even though I have not configured the option to show as expanded, it shows as expanded anyway because it's the selected option.

What I want is for this option to never show as expanded in this block, even if it's selected.

This could be done by respecting the existing "show as expanded" configuration. Or, perhaps there could be a menu setting that determines if selected menu options appear expanded.

The original patch posted by @icurk didn't apply cleanly for me (I'm using Drupal 9.5.3) but I was able to update the patch to work. I will try to add this to the issue. The patch appears to resolve the issue for me in that the menu respects the unchecked "show as expanded" option even when the option is the currently selected option.

As per comment #13, I followed the same steps added for the specific case to reproduce the same.

Created 2 menus

Home
-- home 1
Home 3
--home 4

Home menu -> Checked Show as expanded
Home 3 -> unchecked Show as expanded

For my menu block, I have configured it to show 2 levels to display and I have left the expand all menu links unchecked.

So after all this configuration, Second Menu is not expanded as expected in the feature request without applying any patch.
I have attached the screenshot for all the configurations.

Thank You!

When the issue was reopened should of have been tagged with an issue summary update with why this should remain open and proposed solution.

Also will need test coverage.

In accordance with Comment #13, I meticulously followed the provided steps to reproduce the issue.

Here's a summary of the steps I took:

1. I created two menus:
- Menu 1:
- Home
- test
- Menu 2:
- Home 1
- Home 1

2. Within "Menu 1," I marked "Show as expanded," and in contrast, I unchecked "Show as expanded" for "Home 1" within "Menu 2."

3. For my menu block configuration, I opted to display up to 2 levels and intentionally left the "Expand all menu links" option unchecked.

Despite meticulously configuring the menus and the menu block, the behavior of the second menu did not expand as expected, aligning with the feature request. Your prompt assistance in resolving this matter is greatly appreciated. Thank you!

As of now, it is working as designed and there is no need to apply the patch.

@Nishant2312 based on your description, I do not think you configured your menu correctly to illustrate the problem. Perhaps this could be better explained over a screen sharing session on Slack. I would be happy to schedule something if you feel it would be helpful.