- 🇮🇳India sanket.tale
sanket.tale → made their first commit to this issue’s fork.
- Merge request !86723226309: Moved the svg image to the images folder → (Open) created by sanket.tale
- Status changed to Needs review
10 months ago 11:58am 5 July 2024 - 🇮🇳India sanket.tale
Created MR for the issue please review it.
Steps to reproduce
- example : Go to admin/structure/menu/manage/admin
- Check below menu link Here you can see parent and child link.
- You can see the space before the child menu. If you inspect before the MR you can see the svg tag and after the MR you can see the ::before pseudo element.
Before :-
After :-
- Status changed to Needs work
10 months ago 1:26pm 11 July 2024 - 🇺🇸United States smustgrave
Issue summary should follow standard template.
Also may need submaintainer sign off
- Status changed to Needs review
10 months ago 6:55am 12 July 2024 - 🇮🇳India BhumikaVarshney Delhi
The issue mentioned that svg image code drupal/core/themes/claro/templates/admin/indentation.html.twig added in this template need to be moved to image folder.
But this merge request https://git.drupalcode.org/project/drupal/-/merge_requests/8672/diffs?co... added the same svg by pseudo element.
So need more information do we need to include svg from img tag by using the image source in the url.
As you can refer the
Proposed resolution
Remove the svg tag code from the drupal/core/themes/claro/templates/admin/indentation.html.twig file and create a new svg file in the images folder. - 🇮🇳India ahsannazir
The SVG code has been removed from twig file and SVG has been moved to images/src folder.
- 🇮🇳India Kanchan Bhogade
Hi
I've tested MR 8672 on Drupal 11.x
MR is applied cleanly...Test Result:
The SVG code has been removed from the twig file.Attaching SS for reference
- Status changed to Needs work
9 months ago 8:54am 24 July 2024 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
9 months ago 10:37am 24 July 2024 - Assigned to sagarmohite0031
- 🇮🇳India sagarmohite0031
I have tried to apply MR !8672 but MR is failing.
Please check Error screenshot.
I have applied MR 8672, but when I try to apply it locally, I receive an error. Attached a screenshot.
- Status changed to Needs work
8 months ago 11:39am 20 August 2024 - Status changed to Needs review
8 months ago 7:15am 28 August 2024 - Status changed to Needs work
8 months ago 7:34am 28 August 2024 - Status changed to Needs review
8 months ago 7:00am 6 September 2024 - Issue was unassigned.
- 🇺🇸United States bnjmnm Ann Arbor, MI
This is intentionally added as an SVG document so it can receive CSS styling. This is responsible for the lines that show the relationship between tabledrag items that are seen while dragging. It functions as dynamic element in the UI, not just a background image.
Without the css to conditionally hide/show portions of the SVG this either results in losing the lines altogether or having ALL the lines visible at all times we don't want this 👇 (nor do we want those lines to be removed entirely)