- Issue created by @ptmkenny
- 🇮🇳India JatinGupta40
There are few pipelines erros due to not using of Dependency Injection.
I will resolve them. - 🇮🇳India JatinGupta40
I have checked and the code looks good, and nothing is breaking.
- 🇯🇵Japan ptmkenny
@jatingupta40 Why did you add DI to this issue? That's out of scope for this change, which is about removing deprecations.
- 🇯🇵Japan ptmkenny
I reverted the DI change; DI can break BC and should be dealt with in a separate issue. (The DI issue is reported on the main 2.x branch (https://git.drupalcode.org/project/key/-/pipelines) and is not unique to this issue.
- 🇮🇳India JatinGupta40
Hello @ptmkenny,
I’ve added dependency injection in this code to resolve pipeline failures.
The pipelines were failing earlier, and this change was necessary to fix the issue. - Status changed to Needs review
10 days ago 5:24pm 6 September 2025 - First commit to issue fork.
- 🇮🇳India rajeshreeputra Pune
The
KeyDeprecationTest
still needs to be fixed because the methodgetKeysByStorageMethod()
has been removed from theKeyRepository
, but it is still being referenced in the test. - 🇯🇵Japan ptmkenny
@divyansh.gupta
It looks like you merged the 8.x-1.x branch into this one, but this MR is on the 2.0.x branch, so that merge is incorrect (you need to rebase onto 2.0.x to update, not merge 1.x). Please undo your changes.
- 🇮🇳India divyansh.gupta Jaipur
@ptmkenny,
No i rebased the mr on 2.0.x only, also there are no extra changes showing in Mr and pipelines is also all green,
Please review - 🇯🇵Japan ptmkenny
@divyansh.gupta Ok, thank you for correcting me. I was confused because I saw "f8d2b922 - Merge branch key:8.x-1.x into remove_storage_deprecation", so I incorrectly assumed that you had merged the 8.x-1.x branch.