Remove storage deprecations

Created on 30 May 2025, 4 months ago

Problem/Motivation

Now that the 2.x branch is active, we need to remove the deprecations described in https://www.drupal.org/node/3364701 → .

📌 Task
Status

Active

Version

2.0

Component

Code

Created by

🇯🇵Japan ptmkenny

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @ptmkenny
  • Merge request !56remove storage deprecation → (Open) created by ptmkenny
  • Pipeline finished with Failed
    4 months ago
    Total: 155s
    #510281
  • 🇮🇳India JatinGupta40

    There are few pipelines erros due to not using of Dependency Injection.
    I will resolve them.

  • Pipeline finished with Failed
    3 months ago
    Total: 157s
    #526052
  • Pipeline finished with Canceled
    3 months ago
    Total: 96s
    #526062
  • Pipeline finished with Failed
    3 months ago
    Total: 156s
    #526063
  • Pipeline finished with Failed
    3 months ago
    Total: 163s
    #526071
  • Pipeline finished with Failed
    3 months ago
    Total: 165s
    #526085
  • 🇮🇳India JatinGupta40

    I have checked and the code looks good, and nothing is breaking.

  • 🇯🇵Japan ptmkenny

    @jatingupta40 Why did you add DI to this issue? That's out of scope for this change, which is about removing deprecations.

  • 🇯🇵Japan ptmkenny

    I reverted the DI change; DI can break BC and should be dealt with in a separate issue. (The DI issue is reported on the main 2.x branch (https://git.drupalcode.org/project/key/-/pipelines) and is not unique to this issue.

  • Pipeline finished with Failed
    3 months ago
    Total: 188s
    #526247
  • 🇮🇳India JatinGupta40

    Hello @ptmkenny,
    I’ve added dependency injection in this code to resolve pipeline failures.
    The pipelines were failing earlier, and this change was necessary to fix the issue.

  • Status changed to Needs review 10 days ago
  • First commit to issue fork.
  • Pipeline finished with Failed
    10 days ago
    Total: 201s
    #591818
  • 🇮🇳India rajeshreeputra Pune

    The KeyDeprecationTest still needs to be fixed because the method getKeysByStorageMethod() has been removed from the KeyRepository, but it is still being referenced in the test.

  • 🇮🇳India divyansh.gupta Jaipur

    Working on it !!

  • Pipeline finished with Failed
    8 days ago
    Total: 165s
    #592755
  • 🇯🇵Japan ptmkenny

    @divyansh.gupta

    It looks like you merged the 8.x-1.x branch into this one, but this MR is on the 2.0.x branch, so that merge is incorrect (you need to rebase onto 2.0.x to update, not merge 1.x). Please undo your changes.

  • Pipeline finished with Success
    8 days ago
    Total: 214s
    #593546
  • 🇮🇳India divyansh.gupta Jaipur

    @ptmkenny,
    No i rebased the mr on 2.0.x only, also there are no extra changes showing in Mr and pipelines is also all green,
    Please review

  • 🇯🇵Japan ptmkenny

    @divyansh.gupta Ok, thank you for correcting me. I was confused because I saw "f8d2b922 - Merge branch key:8.x-1.x into remove_storage_deprecation", so I incorrectly assumed that you had merged the 8.x-1.x branch.

Production build 0.71.5 2024