Contact form throws error on submitting

The module sends an email and needs a subject

Can you elaborate on the use case for hiding the subject?

I confirm that hiding the subject causes a fatal error when submitting the form. I don't think we should look for any use cases since this can only be done in the form display settings page. I have encountered this error at least twice and each time I spent a lot of time trying to find the source. We should have some workaround, like additional validation or a default value for the subject.

i am not getting any error even if subject filed is disabled. Do let me know how you are sending email ?

I encounter the error only for anonymous user, debug_backtrace() returns the source of the error like something like "t('@name anonymous', ['@name' => NULL])". As for the current case I do not see any additional mail modules installed and think that finally it is sent by ordinary mail() function.

Thank you very much for your answers.
I think users who send messages through a contact form hate filling useless fields, like the subject field. At least this is my own experience. That is why I always disable subject field (and I always did it), and it was not a problem until upgrading to drupal 11. It was my fault that I did not check the contact form then, so there could have been some clients who faced with the error page since then.
I did not change anything other than uploading the new core and vendor directories. I use the default core email sending mechanism, no other modules (like SMTP or mime mail or such).

Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies → . Restored the issue template. The issue template is used to track progress and various tasks on an issue.

ishani patel → made their first commit to this issue’s fork.

Hello @wahavi
I've followed the above issue steps as you mentioned and got the same error when I disable a subject field.
I resolved that issue and raised an MR
Please check and review.

Thanks

Hi
I've applied MR!11668 and verified on Drupal version on 11.0.x and it is working as expected.

Testing Steps:
1. Installed Contact Module
2. Created a webform and disabled Subject field
3. And oberved the change there.

Testing Result:
After applying the MR the, when user disable the subject field, the form is getting submitted succesfully without error. Attaching SS for reference. As MR have some error so keeping in Needs review status.

Should have a test case showing the issue.

Also issue summary is incomplete.

I am not sure we should deal with this problem in FormattableMarkup but as soon as converting to string already present there let it be... Please review my addition to the tests.

Hi,

I have tested MR 11668 on Drupal 11.x.

I manually verified the functionality by enabling and disabling the Subject field for both logged-in and anonymous users.
The contact form was successfully submitted in all test scenarios.

Attaching Screenshots

Keeping in Need Review for code validation.

Haven't reviewed yet but issue summary appears to be incomplete. Proposed solution needs to be complete as minimum

Thanks

Think we need a test that follows the steps, where the subject is disabled.

No, I believe that problem with contact module is not a source but just a symptom thus we shouldn't test inside of this functional and it's enough to test at the end of the chain as I tried to do at my previous commit.

Will leave for others to review then. Thanks