alezu → made their first commit to this issue’s fork.
The .gitlab-ci file has been added, the tests have been fixed and now pass. Please check.
I see now that 2.0.x version already has the Drupal 11 support. Thanks...
alezu → changed the visibility of the branch 3520734-drupal-11-compatibility to hidden.
No, I believe that problem with contact module is not a source but just a symptom thus we shouldn't test inside of this functional and it's enough to test at the end of the chain as I tried to do at my previous commit.
Hello, I've fixed the reported errors and tested the functionality on Drupal 11. Everything seems working. Please review.
Hi! I've adapted the code to meet Drupal 11 requirements (according to upgrade_status report). Please review and approve merge.
I am not sure we should deal with this problem in FormattableMarkup but as soon as converting to string already present there let it be... Please review my addition to the tests.
I encounter the error only for anonymous user, debug_backtrace() returns the source of the error like something like "t('@name anonymous', ['@name' => NULL])". As for the current case I do not see any additional mail modules installed and think that finally it is sent by ordinary mail() function.
I confirm that hiding the subject causes a fatal error when submitting the form. I don't think we should look for any use cases since this can only be done in the form display settings page. I have encountered this error at least twice and each time I spent a lot of time trying to find the source. We should have some workaround, like additional validation or a default value for the subject.
I've tested it and it seems that the error is gone. Thanks, waiting for the new release.
Sorry, my fault - I meant that the menu item should be placed a level higher and has parent commerce.configuration
Changes commited to https://www.drupal.org/project/b24/releases/2.0.13 →
Hello alexjluna!
Sorry fore late response. Could you describe me a context where we need these methods in? I mean the aim is not clear enough for me now.
Merged to 2.0.x
Hello @selpi, thanks for your report!
@sarwan_verma, alas but the solution you provided does not work for Drupal 11 as it requires this variable. See https://www.drupal.org/node/3404140 → for the details.
I've published the new release where I removed this variable definitions from any setting forms. I have not covered the code with tests yet but locally it works now either for D10.3.5 or for D11. Please check and review.
Hi Anche, there is an example of workaround for a similar case. https://drupal-coder.ru/blog/privatnye-kartinki-ckeditor-drupal-dinamich...
The post is in Russian but everything is clear from the code.
Let me put this temporary patch for CKEditor5 here.
Just for note - at least the old ckeditor seems to be loaded without any context, so it's hardly possible to use any tokens except global ones there.
@xpersonas there is a way, described here:
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... →
You will be interested in point #6.
@xpersonas, wouldnt't it be better for you to request for a maintainer role for this module?
I've fixed the issue in the latest release. Not the most ideal solution but works.