Allow tokens to be used in Text Editor/CKEditor 5 image upload directory path

Closed ✨ CKEditor 5 doesnt support directory tokens for inline images Closed: duplicate as a duplicate of this.

This patch is correctly updating editor_image_upload_settings_form() and EditorImageDialog. But EditorImageDialog is going away: 📌 Deprecate EditorLinkDialog, EditorImageDialog and EditorMediaDialog in Drupal 10.1 for removal in Drupal 11 Fixed . Still, CKEditor 5's \Drupal\ckeditor5\Plugin\CKEditor5Plugin\Image::buildConfigurationForm() continues to call editor_image_upload_settings_form().

Which brings up an interesting question … perhaps this should actually be converted into a CKEditor 5 issue? due to #3231341, the bulk of the changes would actually have to happen in the CKEditor 5 module, not the Text Editor module?

Also related: 🌱 [META] Discuss: merge the Editor config entity into the FilterFormat config entity Active , at which point it quite possibly makes sense to drop \Drupal\editor\EditorInterface::getImageUploadSettings() altogether? The very reason that configuration was stored on the general Text Editor config entity was to maximize the ability to switch between different text editors back in #1833716: WYSIWYG: Introduce "Text editors" as part of filter format configuration → , over 10 years ago 😳, by putting configuration that could be shared between text editors in the general Text Editor config entity rather than the text-editor-plugin-specific settings.

But in that decade, no notable alternative text editor has sprung up in the contributed module space. So why keep this API surface complexity? Why not drop it exactly at the time when we are modifying EditorInterface anyway (i.e. merging it with FilterFormatInterface).

Tagging for that.

For Ckeditor5 in drupal 10, 1 line code change could fixed it:

change

$destination = $image_upload['scheme'] . '://' . $image_upload['directory'];

to

$destination = $image_upload['scheme'] . '://' . \Drupal::token()->replace($image_upload['directory']);

in upload function of file core\modules\ckeditor5\src\Controller\CKEditor5ImageController.php

Akshay kashyap → made their first commit to this issue’s fork.

@Wim Leers so should we block this on 🌱 [META] Discuss: merge the Editor config entity into the FilterFormat config entity Active ? My gut feel is that we should do the smallest change possible here and only change ckeditor5. And if 🌱 [META] Discuss: merge the Editor config entity into the FilterFormat config entity Active goes ahead it'll take care of the other stuff in #30.

FWIW we can use \Drupal::token()->replacePlain() here.

#34 makes it sound like this should be postponed. Or moved to ckeditor5.

Let me put this temporary patch for CKEditor5 here.
Just for note - at least the old ckeditor seems to be loaded without any context, so it's hardly possible to use any tokens except global ones there.

all these patches work only with the date? I'm trying [node:nid] and it doesn't work (#38) :(

Hi Anche, there is an example of workaround for a similar case. https://drupal-coder.ru/blog/privatnye-kartinki-ckeditor-drupal-dinamich...
The post is in Russian but everything is clear from the code.

Alezu, thanx a lot! It helps me.
на русском то, что надо! ;)

here's a reroll of the temporary fix in #38 that should work with 10.3.0

Patch #42 worked with Drupal 10.3.6 too!

I tested inline-files/[date:custom:Y]-[date:custom:m] as suggested in issue body.

Maybe we want separate follow up issues for:

• improving the UX, for example by adding a link to Browse available tokens
• making other tokens (non-globally available ones) work, for example related to the parent entity having the CKE text field (for example [node:nid] doesn't work, as expected?).

Moving back to needs work since the "needs test" tag is on the issue and I haven't seen any test coverage in MR#3891 so far.

Patch #42 works in Drupal 10.3.10.

Personally, I think this is is quite a crucial feature to have because without it, sites' sites/default/files/inline-images folders will be in danger of becoming dangerously bloated, I know mine is!