- 🇳🇿New Zealand quietone
And now the Ideas project is being deprecated. This issue is moved to the Drupal project. Check that the selected component is correct. Also, add the relevant tags, especially any 'needs manager review' tags.
- 🇳🇿New Zealand quietone
The Ideas project is being deprecated. This issue is moved to the Drupal project. Check that the selected component is correct. Also, add the relevant tags, especially any 'needs manager review' tags.
- 🇳🇿New Zealand quietone
Following on from #8, there hasn't been support from others to help create a group to take this on as an initiative.
Shall we close this?
- 🇦🇺Australia mstrelan
I don't think we should be using
@return foo|void
. If we want to add a native return type later this is invalid, it has to either return something or not.For
_batch_next_set
it's called by_batch_process
which treats the return as a bool, so for that one I think we could just return FALSE.For
batch_process
the places that call it seem to check if the return value is aResponse
or not, so we should return NULL otherwise. Similar for_batch_queue
, not sure why we wouldn't return NULL here.install_run_task
should quite obviously return NULL and not void. It's called like this:$output = install_run_task($task, $install_state);
. If we return void it just gets coerced to NULL anyway. Same forinstall_get_form
which is called frominstall_run_task
I'm happy to work on this if people agree with this point of view.