- Merge request !1497Issue #3253158: Add Alpha level Experimental Automatic Updates module → (Open) created by tedbow
The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Postponed
over 1 year ago 10:31am 16 March 2023 - 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
Because Automatic Updates needs a comprehensive review, including a security review. But that means drupal.org's PHP-TUF support needs to be deployed, otherwise core committers would need to do multiple security review rounds: once for the Automatic Updates module, once for the d.o PHP-TUF support.
Follow 📌 Add a validator to check that PHP-TUF's Composer integration is present and configured correctly Fixed if you want to be notified of when that is ready.
This is why the decision was made to aim to first land Package Manager (which provides the necessary infrastructure for Automatic Updates) as alpha-experimental in ✨ Add Alpha level Experimental Package Manager module Needs review .
- 🇺🇸United States effulgentsia
📌 Add a validator to check that PHP-TUF's Composer integration is present and configured correctly Fixed landed, so this now has only one blocker, ✨ Add Alpha level Experimental Package Manager module Needs review , though that issue has several (see the top section of 🌱 Drupal 10 Core Roadmap for Automatic Updates Active for details).
- Open on Drupal.org →Environment: PHP 8.2 & MySQL 8last update
8 months ago Not currently mergeable. - last update
8 months ago 31,151 pass, 16 fail - Status changed to Needs review
8 months ago 11:20pm 15 October 2023 25:47 2:03 Running- Status changed to Needs work
8 months ago 12:12pm 29 October 2023 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇺🇸United States tedbow Ithaca, NY, USA
The current merge request is not up-to-date with the work in the contrib module
There is automated script to convert module it but it is still a fair amount of work. For this reason and because we aren't actually getting reviews, nobody outside of the team working on the contrib module has commented since February, I am going stop running conversions.
If you want to review the code I would suggest reviewing the contrib module which the MR here has always been a automated conversion of. https://www.drupal.org/project/automatic_updates →
When core reviewers have time especially the product, release and framework managers and if you would like to review the module here instead of the contrib module please contact me or comment here and I can run the conversion again.
I tempted to postpone but I won't for now
- 🇬🇧United Kingdom catch
It's hard to tell from the issue summary what work is remaining before AU is ready for alpha commit.
🌱 Drupal 10 Core Roadmap for Automatic Updates Active is now linked from the issue summary (it wasn't before), but it's not very scannable to see e.g. that 🐛 Exceptions in batch no longer are shown on the page when Javascript is disabled Needs work is blocking - I think it would be help to link those issues directly here - especially ones that will require changes to AU code but also any core bugs that aren't specific to AU.
- 🇬🇧United Kingdom catch
The MR is green again, should this be needs review? If not, what is blocking a review here?
- Status changed to Needs review
about 2 months ago 1:44pm 25 April 2024 - Status changed to Needs work
about 2 months ago 2:32pm 25 April 2024 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
about 2 months ago 4:58pm 26 April 2024 - 🇺🇸United States tedbow Ithaca, NY, USA
Pushing up the new conversion.
I do expect
\Drupal\Tests\package_manager\Kernel\StageBaseTest::testDestroyDuringApply
to fail. There is some serialization problem that is not happening the contrib module against 11.x. Not sure whyBut I think it is still reviewable
- 🇺🇸United States tedbow Ithaca, NY, USA
Removing "[PP-1] " not postponed as far as reviewing. ✨ Add Alpha level Experimental Package Manager module Needs review still needs to be committed first
Issue summary clean-up
- Change 3.0.x to 3.1.x
- Mention 🌱 [policy, no patch] Drop support for Windows in production Needs review as reason not support background updates on Windows
- Status changed to Needs work
30 days ago 10:52pm 19 May 2024 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.