The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇮🇳India nikhil_110
Attached patch against Drupal 10.1.x
Patch #28 is not applied for Drupal 10.1.x so Inter-diff file is not added.
- Status changed to Needs review
almost 2 years ago 9:56am 7 April 2023 - Status changed to Needs work
almost 2 years ago 3:19pm 7 April 2023 - 🇺🇸United States smustgrave
@Nikhil_110 just because a patch doesn't apply doesn't mean a diff can't be generated fyi
To me this is works as designed
On this page not sure if changing the button makes sense since you have the Update tab right there.
Possibly could introduce BC issues.
- Status changed to Closed: won't fix
over 1 year ago 5:28am 5 August 2023 - 🇳🇿New Zealand quietone
The label of the button was changed in #2577407: Action of uploading module/theme files should consistently be called "Add", not "Install" → in 9.2.x. That type of change should have been a flag that research was needed before continuing to work on the patch. Related changes are important. The other issue is a more thorough look into the actions of this button and related ones as well as the displayed text.
The change here is changing the action of the button, which was discussed in the other issue and left as is. The change here is not typical of what I see in the Drupal UI, that it is adds a button that links to a page that is also a menu task. It is not adding functionality, merely duplicating it on the same page.
There is a somewhat related issue about having this 'install' page in the report hierarchy, which I am adding as a related issue.
At best this issue is duplicate of #2577407: Action of uploading module/theme files should consistently be called "Add", not "Install" → but because of changing the button to be the same as a menu item, I am selecting won't fix.