- Issue created by @e0ipso
- e0ipso Can Picafort
Updated the date to be more precise about how much time is left. About 1 month and a half to cross the finish line!
- 🇺🇸United States mherchel Gainesville, FL, US
Updating issue summary to add the issue for Olivero to use SDC: 📌 Create new SDC component for Olivero (tabs) Postponed
- 🇺🇸United States mherchel Gainesville, FL, US
Adding 📌 Move code from the experimental SDC module to core Fixed as stable blocker.
- 🇺🇸United States mherchel Gainesville, FL, US
Adding 📌 [SDC] Validate and improve developer experience and helpfulness of error messages Active as stable blocker.
- 🇺🇸United States mherchel Gainesville, FL, US
Adding 📌 [META] SDC: Improve and extend documentation Fixed as stable blocker.
- 🇺🇸United States mherchel Gainesville, FL, US
Removing "Remove the experimental status" as a stable blocker. The plan is to fold SDC directly into core, and thus it will not be able to be experimental.
- 🇺🇸United States mherchel Gainesville, FL, US
Adding 📌 If needed, create automated tests to validate SDC's use of Drupal escaping and Twig sandboxing Active as stable blocker.
- 🇺🇸United States mherchel Gainesville, FL, US
Adding 📌 SDC: Prevent unwanted context passing with Twig include/embed functions Active as a non-stable blocker.
- 🇺🇸United States mherchel Gainesville, FL, US
Adding 📌 Create SDC "Quick start" documentation / code Fixed as stable blocker.
- e0ipso Can Picafort
I created 📌 Mark SDC as beta so it can be included in 10.1 Fixed to discuss marking SDC as beta stability before 10.1.0-alpha1 is tagged. This will mean that SDC will be available as an experimental module in 10.1.
- e0ipso Can Picafort
There was a video call meeting with the Front-end Framework Manager team where we went over each one of the remaining tickets. We confirmed that the tickets marked as stable blockers are indeed that, and not beta blockers.
The attendants to the meeting where:
- @lauriii
- @ckrina
- @bnjmnm
- @n0d_
- @mherchel
- @e0ipso
This was documented in comment #129 ✨ Add Single Directory Components as a new experimental module Fixed of ✨ Add Single Directory Components as a new experimental module Fixed , but referencing here for convenience.
- 🇺🇸United States dww
Removing 📌 Move makePathRelative from SDC to the FileSystem component Closed: won't fix which we determined is "won't fix".
- e0ipso Can Picafort
Added 📌 [PP-1] Remove schema references from contrib in SDC tests in core Postponed .
- e0ipso Can Picafort
I found a bug while using the beta: 🐛 Unable to override library auto-definition to add external CSS & JS Fixed . There is a workaround listed in the issue.
- e0ipso Can Picafort
Added an issue for a warning related to the locale module upon cache clears. I have only been able to reproduce this using Umami so far. 🐛 _locale_parse_js_file cannot open SDC JavaScript files Closed: works as designed
- e0ipso Can Picafort
Updated the roadmap to add links to the meta issues to add components to Olivero and Umami, replacing the links to specific component migrations.
- 🇳🇱Netherlands bbrala Netherlands
Changing target branch to 10.1.x.
Plan is to create a merge request here for 10.2.x and then create seperate issues per namespace or if needed per file so we can discuss where those classes should end up in core when the module exists experimental status.
- 🇺🇸United States mherchel Gainesville, FL, US
- 🇺🇸United States mherchel Gainesville, FL, US
Adding 🐛 [SDC] Improve error handling during prop validation errors Fixed
- 🇺🇸United States mherchel Gainesville, FL, US
Adding 🐛 Unhelpful error message with SDC when a optional variable is missing Closed: duplicate
- e0ipso Can Picafort
✨ [PP-1] Allow schema references in Single Directory Component prop schemas Postponed will require the promotion of
justinrainbow/json-schema
to a runtime dependency (currently require-dev). We'll need to vet the library in [], and it is unclear if we want to do so.I don't think this should be a blocker for stability, but a nice-to-have.
- 🇺🇸United States mherchel Gainesville, FL, US
I would love to have it as a runtime dependency. We had several folks who didn't realize that it needed to be installed for SDC to output helpful error messages. Having it as a runtime dependency would improve the DX.
- e0ipso Can Picafort
I think the first steps towards stability are:
- e0ipso Can Picafort
Added 📌 [SDC] Add a test for multiple *.component.yml in the same directory Active as non-blocking.
- 🇺🇸United States mherchel Gainesville, FL, US
Adding 🐛 SDC Stylesheets are output in the wrong order (relating to normal libraries) Active as a stable blocker. Discussion in Slack at https://drupal.slack.com/archives/C4EDNHFGS/p1690469220405819
- e0ipso Can Picafort
Added another stable blocker 📌 Allow other Twig node visitors to modify 'display_start' and 'display_end' Active . So great that people are trying this!
- e0ipso Can Picafort
Added another stable blocker: 🐛 SDC componentMetadata does not take the right context when a component is extended Active .
- 🇪🇸Spain rodrigoaguilera Barcelona
There is now umami SDC components so removing it from stable blockers
- e0ipso Can Picafort
Removing 🐛 SDC Stylesheets are output in the wrong order (relating to normal libraries) Active from the list. After some investigation, we notice this one is not specific about SDC.
- e0ipso Can Picafort
🐛 Components without props throw error Fixed is the only code issue left inside the
core/modules/sdc
folder blocking 🌱 [META] Create Single Directory Components for the Olivero theme Active . - e0ipso Can Picafort
🐛 Components without props throw error Fixed is now fixed. One less blocker!
- e0ipso Can Picafort
I don't think we can make 🌱 [META] Create Single Directory Components for the Olivero theme Active a stable blocker without changing Olivero's policy that prevents depending on experimental modules. My thinking is that we want to make SDC stable, and then start using it in Olivero.
Based on this I am moving it to the non-stable blocker section.
- e0ipso Can Picafort
Triaging issues. I moved these (completed) items under the stable blocker section:
- 🇨🇦Canada xmacinfo Canada
Any dependency between Olivero and SDC must be optional so that a user is not obligated to enable SDC just to use Olivero or take Olivero as a base theme.
- e0ipso Can Picafort
@xmacinfo all users will be using SDC when this issue lands. It will no longer be a module to be enabled, but something that Drupal allows, like support for postgres, Form API, or the render cache. You'll still be free to use it or not.
- 🇨🇦Canada xmacinfo Canada
You'll still be free to use it or not.
If I build a theme based on the Olivero SDC variant, will I be able to override some or all SDC components included in Olivero once SDC is incorporated in Drupal (not a module anymore)?
- e0ipso Can Picafort
Added a new stable blocker. This is a follow up that is 11.x only to remove some leftovers due to the BC dance.
📌 Remove SDC deprecated twig functions before 11.0.0 Postponed
- e0ipso Can Picafort
@xmacinfo correct! Take a look at the official documentation → for the specific details.
- 🇨🇦Canada xmacinfo Canada
Overriding an SDC component with another one makes sense.
But, actually, my question is more like:
Can I override the need for a SDC component. In other words, override SDC altogether.
For example, I create a new theme based on Olivero, but I want to use regular templates instead on a component. Can this be done or will I be locked in SDC?
- e0ipso Can Picafort
@xmacinfo I think we should move this chat over to 🌱 [META] Create Single Directory Components for the Olivero theme Active and leave this to the stabilization discussions. Would that work for you?
- e0ipso Can Picafort
Adding ✨ Mark sdc as obsolete for 11.x Active as a stable blocker.
- e0ipso Can Picafort
Adding ✨ [PP-1] Remove the sdc module from core on 12.x Postponed as a non-stable-blocker.
- e0ipso Can Picafort
Adding 📌 Document deprecation in drupal.org documentation pages Active as a non-stable-blocker.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
📌 Move code from the experimental SDC module to core Fixed is in … does that mean this can be closed? 😄
- e0ipso Can Picafort
I think the necessary follow ups after 📌 Move code from the experimental SDC module to core Fixed have all been addressed. They were all included in 📌 Remove SDC deprecated twig functions before 11.0.0 Postponed .
I am inclined to close this issue as well.
- 🇫🇷France andypost
DX improvement 📌 Unhelpful PHP error with NULL type property Needs review