[SDC] Improve error handling during prop validation errors

Here's the error that I found when there's an empty object

@sharkbaitdc, can you please share the scenario where you found the error above just so I try to reproduce and see if the patch fixes it?

Thanks :)

After talking with e0ipso it seems like documenting the way to correctly type empty values is the path forward. There are two main cases that we are likely to encounter

• Array found expecting Object
• Null found expecting Anything(string, number, array, etc)

In both cases the solution is to use the |default() filter to set the correct empty value.

Another thought was to try and capture this type of error in the validator and in the error message link to the fix on drupal.org.

Opened a MR that does two things
- Enables fuzzy type casting for arrays and objects during validation using Constraint::CHECK_MODE_TYPE_CAST from the validation library https://github.com/justinrainbow/json-schema
- Check the error messages for a NULL found error and append additional context that points people to the most likely problem/solution which is that the empty data value and the populated data value have different types. I wasn't able to find an easy way to check the schema against the props which is why I checked the error message text instead of a more thorough approach.

Can the issue summary be updated with steps to reproduce and the proposed solution please.

Updated summary and added a test only patch.

Wrong parent, sorry.

Admitedly, this should be a stable blocker.

e0ipso → credited sarahjean → .

Suggesting credit to @sarahjean for the report in 🐛 Unhelpful error message with SDC when a optional variable is missing Closed: duplicate .

The last submitted patch, 8: 3365480--8--test-only.patch, failed testing. View results →

Hiding the tests-only patch so the review bot doesn't send back to NW.

Issue summary also looks good! Thanks for that.

Reviewing MR 4141 and following the steps of the issue summary can confirm the issue and that it has been fixed.

Fix typo in issue title.

I was converting pager into a sdc and one of the variables passed is the ellipse object which can be empty depending on the page you’re on.

Committed 80174a6 and pushed to 11.x. Thanks!

Cherry-picked to 10.1.x because it's a non-disruptive bug fix to an experimental module.

lauriii → closed merge request !4141

Automatically closed - issue fixed for 2 weeks with no activity.

There's follow-up to improve error message, it missing component name at least 📌 Unhelpful PHP error with NULL type property Needs review