- Issue created by @mherchel
- @mherchel opened merge request.
- πΊπΈUnited States mherchel Gainesville, FL, US
Adding testing instructions.
- Status changed to Needs review
almost 2 years ago 2:47pm 11 March 2023 - Status changed to Needs work
almost 2 years ago 4:35pm 13 March 2023 - πΊπΈUnited States smustgrave
Seems to have some failures https://dispatcher.drupalci.org/job/drupal_patches/171690/console
- πΊπΈUnited States mherchel Gainesville, FL, US
This can't pass until SDC is committed to core. The failures are because the tabs component is missing (because SDC is currently non-existent in core)
- Status changed to Postponed
almost 2 years ago 4:59pm 13 March 2023 - πΊπΈUnited States smustgrave
Saw that after I placed my comment. So moving to postponed until that gets committed.
- Status changed to Needs work
over 1 year ago 4:05pm 3 June 2023 - e0ipso Can Picafort
SDC is committed to core. Let's put this back in scope.
- First commit to issue fork.
- @kostyashupenko opened merge request.
- π·πΊRussia kostyashupenko Omsk
Please correct me if i'm wrong.
I have no permissions to change target branches (because actual target branch should be 11.x). I also have no permissions to close merge requests.
So i created new branch against 11.x and cherry-picked commits of Mike in there. Going to complete this issue soon today
- π·πΊRussia kostyashupenko Omsk
Actually... how to complete this issue?)))
The main problem here is a dependency to `sdc` core module. But... this module is not required by standard profile installation https://git.drupalcode.org/project/drupal/-/blob/11.x/core/profiles/stan...
which means we can't just.. declare dependency in olivero theme to sdc module, rewrite twig files, remove drupal library from olivero.libraries.yml, etc. Main thing is what if on existing web-sites sdc is disabled? So after migration to the latest drupal they will lose tabs visual coz module sdc is not enabled (and actually not sure, maybe they will get fatal error coz olivero have dependency to the module which is disabled). And not sure if there is plans to have sdc module enabled by default in standard profile installation.
Anyways, any thoughts?
- Status changed to Postponed
over 1 year ago 12:49pm 28 July 2023 - πΊπΈUnited States smustgrave
You can add sdc to standard profile for testing. But technically this would be postponed until sdc is marked stable
- π¨π¦Canada xmacinfo Canada
Even when SDC is marked as stable. SDC must be optional and not be forced into any existing core theme or core modules.
We still want to be able to install Drupal without enabling SDC.