Allow other Twig node visitors to modify 'display_start' and 'display_end'

IMO (at a first glance) this is also a stable blocker.

Changed base branch.

Re-rolled against 11.x and fixed some phpcs issues to allow tests to run. Thanks @lussoluca and @DieterHolvoet!!

Hmmm, for some reason the GitLab UI to generate a new branch from 11.x did not work as I was expecting. I updated it manually.

All tests are passing. This confirms the static code review.

Next step before RTBC is for @lussoluca to confirm that the current MR (on the updated 11.x branch) works along with the Tracer module.

I confirm that everything still works as expected

Confirming the RTBC based on my code review, the green tests, and Lucca's manual testing.

Is this something we could test in core? Maybe we could write a test module that does something similar to Tracer to make sure that we don't break this.

I can work on it.

Leaving assigned to @lussoluca.

Moving to NW per #13

Test added, let me know if it's ok

Only rebased to run the test-only run and tests failed as expected

There was 1 error:
1) Drupal\Tests\sdc\Kernel\ComponentNodeVisitorTest::testOtherVisitorsCanModifyTwigNodes
PHPUnit\Framework\Exception: Unavailable module: 'sdc_other_node_visitor'. If this module needs to be downloaded separately, annotate the test class with '@requires module sdc_other_node_visitor'.
/builds/issue/drupal-3375843/core/tests/Drupal/KernelTests/KernelTestBase.php:537
/builds/issue/drupal-3375843/core/tests/Drupal/KernelTests/KernelTestBase.php:387
/builds/issue/drupal-3375843/core/tests/Drupal/KernelTests/KernelTestBase.php:261
/builds/issue/drupal-3375843/core/modules/sdc/tests/src/Kernel/ComponentKernelTestBase.php:56
/builds/issue/drupal-3375843/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
--
There was 1 risky test:
1) Drupal\Tests\sdc\Kernel\ComponentNodeVisitorTest::testOtherVisitorsCanModifyTwigNodes
This test did not perform any assertions
/builds/issue/drupal-3375843/core/tests/Drupal/Tests/Listeners/DrupalListener.php:65
/builds/issue/drupal-3375843/vendor/phpunit/phpunit/src/Framework/TestResult.php:452
/builds/issue/drupal-3375843/vendor/phpunit/phpunit/src/Framework/TestSuite.php:684
/builds/issue/drupal-3375843/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:651
/builds/issue/drupal-3375843/vendor/phpunit/phpunit/src/TextUI/Command.php:144
/builds/issue/drupal-3375843/vendor/phpunit/phpunit/src/TextUI/Command.php:97
ERRORS!
Tests: 1, Assertions: 0, Errors: 1, Risky: 1.

Looking at the change it makes sense and does seem to solve the issue.
Tested on Umami which has SDC enabled with a disclaimer component.

lauriii → closed merge request !4867

Crediting @DieterHolvoet for working on 🐛 Error: Call to a member function leave() on null Postponed: needs info which I believe is a duplicate.

Committed a6aabb7 and pushed to 11.x. Also cherry-picked to 10.2.x and 10.1.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.