- Issue created by @plopesc
- e0ipso Can Picafort
This is postponed until π Move code from the experimental SDC module to core Fixed is merged.
- Status changed to Active
8 months ago 2:01pm 28 March 2024 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
π Move code from the experimental SDC module to core Fixed landed!
- Merge request !7238Resolve #3409456 "Remove SDC deprecated code before 11.0.0" β (Closed) created by plopesc
- Status changed to Needs review
8 months ago 11:27pm 28 March 2024 - πͺπΈSpain plopesc Valladolid
Created MR where SDC module is completely removed from the codebase and references to deprecated twig functions and LibraryDiscoveryParser service parameters BC layer are moved as well.
- Status changed to RTBC
8 months ago 2:06pm 29 March 2024 - πΊπΈUnited States smustgrave
Removal seems good/didn't break anything.
Congrats on this one!
- Status changed to Needs work
8 months ago 2:25pm 29 March 2024 - π¬π§United Kingdom catch
sdc shouldn't got directly from deprecated to removed, it needs to go to obselete first. That should also come with a post update to uninstall itself. This ensures that the module is uninstalled before it's remove from the filesystem. Otherwise someone who leaves it enabled and updates to Drupal 11 will get a nearly-unrecoverable PHP error about the missing module, and the only way to resolve it is to restore a backup, or manually create a stub so it can be uninstalled cleanly.
- Status changed to Needs review
8 months ago 9:33am 1 April 2024 - πͺπΈSpain plopesc Valladolid
Thank you for the heads up.
Brought back the SDC module info file stub and added post_update hook to uninstall it.
Finally added section https://www.drupal.org/docs/core-modules-and-themes/deprecated-and-obsol... β to reflect the module situation
- Status changed to RTBC
8 months ago 2:30pm 1 April 2024 - πΊπΈUnited States smustgrave
Verified link https://www.drupal.org/node/3223395#s-sdc β correctly goes to SDC
Ran post_update hook locally and it ran fine without issue.
- Status changed to Needs work
8 months ago 3:33pm 1 April 2024 - π¬π§United Kingdom alexpott πͺπΊπ
Sorting out issue credit... needs to have 11.x merged in to fix conflicts.
- Status changed to Needs review
8 months ago 4:03pm 1 April 2024 - πͺπΈSpain plopesc Valladolid
Branch updated with latest changes from 11.x and tests are green again.
- Status changed to RTBC
8 months ago 1:49pm 2 April 2024 - Status changed to Fixed
8 months ago 10:41am 3 April 2024 -
alexpott β
committed b8037acd on 11.x
Issue #3409456 by plopesc, smustgrave, quietone, e0ipso, catch: Remove...
-
alexpott β
committed b8037acd on 11.x
- e0ipso Can Picafort
π Document deprecation in drupal.org documentation pages Active and β¨ Mark sdc as obsolete for 11.x Active are both closed by this commit.
Automatically closed - issue fixed for 2 weeks with no activity.