- Issue created by @bbrala
- Merge request !8Draft: Issue #3364713 by lauriii, bnjmnm, andy-blum, Dave Reid, cosmicdreams: Claro:... β (Merged) created by bbrala
- First commit to issue fork.
- Status changed to Needs review
12 months ago 3:04pm 5 December 2023 - πͺπΈSpain plopesc Valladolid
- Status changed to Needs work
12 months ago 11:44pm 5 December 2023 - πΊπΈUnited States smustgrave
So do think the BC dance will have to be done for this to be merged into 10.x
- Status changed to Needs review
12 months ago 8:21am 6 December 2023 - πͺπΈSpain plopesc Valladolid
BC changes are now in place. Thank you for the heads-up!
- Status changed to Needs work
12 months ago 2:32pm 6 December 2023 - πΊπΈUnited States smustgrave
Not sure I see the deprecation
if (!isset($languageManager)) { @trigger_error('Calling ' . __METHOD__ . '() without the $language_manager argument is deprecated in drupal:10.1.0 and will be required in drupal:11.0.0. See https://www.drupal.org/node/3347754', E_USER_DEPRECATED); $this->languageManager = \Drupal::languageManager(); }
Is what most of core is doing, probably want to follow that blueprint.
- Status changed to Needs review
12 months ago 3:47pm 6 December 2023 - πͺπΈSpain plopesc Valladolid
Thank you for your review @smustgrave.
BC compatibility approach has been modified to follow the example given above.
- Status changed to RTBC
12 months ago 4:35pm 11 December 2023 - Status changed to Fixed
11 months ago 4:44pm 18 December 2023 - e0ipso Can Picafort
It looks great!
We added π Remove SDC deprecated twig functions before 11.0.0 Postponed as part of this.
Automatically closed - issue fixed for 2 weeks with no activity.