WI: Phase D: Enable archive/purge storage

Created on 14 May 2016, over 8 years ago
Updated 23 July 2024, 4 months ago

Note: This issue is part of #2721129: Workflow Initiative and is only meant for planning and governance sign-offs. Work will happen in child issues of this plan.

Some historic background: #147723: Deletion API for core and http://drupal4hu.com/node/233

This phase will introduce two new methods in the content entity storage: softDelete() and forceDelete(). This is primarily important for replication and conflict management (see phase H ) but also enables things like Trash module (see phase E ).

The softDelete() method is the logical replacement of the traditional delete method. But instead of erasing the entity from the database, it will save a new revision with a timestamp base field called "deleted_at" set to the current request time. The entity query and storage API will add conditions on this base field where necessary. This method will also invoke a new hook called hook_entity_softdelete().

The forceDelete() method will erase an entity from the database and invoke hook_entity_forcedelete(). The forceDelete() method will also invoke the deprecated hook_entity_delete() for backward compatibility reasons, as the traditional behaviour of this hook is to erase things from the database.

The softDelete() and forceDelete() methods also have more explicit names to what they actually do, while delete() is more ambiguous.

Sign-offs needed

Product manager

A product manager needs to sign-off on this plan as the above phases are required as part of a planned initiative.

Framework manager

A framework manager needs to sign-off on this plan as the above phases introduces major API additions (archive and purge).

Sub-system maintainers

The sub-system maintainers for the Entity API needs to sign-off on this plan as it significantly impacts the Entity API.

Sign-offs given

  • Product manager - pending
  • Framework manager - pending
  • Sub-system maintainers - pending
🌱 Plan
Status

Closed: won't fix

Version

11.0 🔥

Component
Entity 

Last updated about 3 hours ago

Created by

🇫🇷France dixon_ France

Live updates comments and jobs are added and updated live.
  • Needs product manager review

    It is used to alert the product manager core committer(s) that an issue represents a significant new feature, UI change, or change to the "user experience" of Drupal, and their signoff is needed. If an issue significantly affects the usability of Drupal, use Needs usability review instead (see the governance policy draft for more information).

  • Needs framework manager review

    It is used to alert the framework manager core committer(s) that an issue significantly impacts (or has the potential to impact) multiple subsystems or represents a significant change or addition in architecture or public APIs, and their signoff is needed (see the governance policy draft for more information). If an issue significantly impacts only one subsystem, use Needs subsystem maintainer review instead, and make sure the issue component is set to the correct subsystem.

  • Needs subsystem maintainer review

    It is used to alert the maintainer(s) of a particular core subsystem that an issue significantly impacts their subsystem, and their signoff is needed (see the governance policy draft for more information). Also, if you use this tag, make sure the issue component is set to the correct subsystem. If an issue significantly impacts more than one subsystem, use needs framework manager review instead.

  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇳🇿New Zealand quietone

    The release managers discussed this at the end of May and I am only now commenting. We noted that this is part of the Workflow Initiative but that initiative has ended and there isn't anything here for us to review. We also are aware that there is the Trash module and a core issue to move that to core, 📌 Add experimental Trash module Active .

    This issue was also closed; as won't fix in 2017 and then re-opened in 2019. But since then there has been no activity here despite a prompt for more information 2 years ago. After 5 years without comment here from someone from the workflow initiative it seems sensible to restore the won't fix from 2017.

    And, if that there is a desire to add this to core, then it would be better to start fresh with a new initiative or plan. Therefore, I am going to close this. I trust someone will correct that if it is wrong.

Production build 0.71.5 2024