Add experimental Trash module

Created on 8 September 2016, almost 9 years ago
Updated 17 January 2023, over 2 years ago

Problem/Motivation

The Trash module currently exists in contrib, as part of the Workflow Initiative we hope to move it into core.

Proposed resolution

- Port Trash module to depend on the archived state in Content Moderation rather then Multiversion
- Update Trash module to be an experimental core module

Remaining tasks

Postponed on 📌 Mark Workspaces as a stable core module Fixed

User interface changes

API changes

Data model changes

📌 Task
Status

Postponed

Version

10.1 ✨

Component
Other  →

Last updated 2 days ago

Created by

🇬🇧United Kingdom timmillwood 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

  • Needs product manager review

    It is used to alert the product manager core committer(s) that an issue represents a significant new feature, UI change, or change to the "user experience" of Drupal, and their signoff is needed. If an issue significantly affects the usability of Drupal, use Needs usability review instead (see the governance policy draft for more information).

  • Usability

    Makes Drupal easier to use. Preferred over UX, D7UX, etc.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇫🇮Finland lauriii Finland

    Would it be possible to document why the decision was made to postpone this on the Workspaces? This module doesn't directly depend on Workspaces so it isn't self-explanatory why we would make it a hard blocker for this issue.

  • 🇬🇧United Kingdom catch

    @lauriii we shouldn't add a new experimental module that is dealing with deep entity system architecture while we have one already in core that's not stable yet. And more specifically, the time spent working on trash module instead of resolving fundamental blockers to workspaces being is part of the reasons it didn't reach stable 2-3 years ago.

  • Status changed to Active about 1 year ago
  • 🇳🇿New Zealand quietone

    No longer postponed on Workspaces

  • 🇬🇧United Kingdom catch

    Note there's now a stable trash module in contrib https://www.drupal.org/project/trash →

    I haven't personally used it, but I believe it is the result of @amateescu's comment in #50.

  • 🇯🇴Jordan Rajab Natshah Jordan

    Would the Trash → module be added to Drupal Core, or was it settled on only having it in Drupal CMS?

  • 🇬🇧United Kingdom catch

    @rajab natshah that's what this issue is for deciding. For me personally I don't think there's an urgent need to have it in core because as far as I know it stable and working well in contrib. On the other hand 📌 Allow for / implement simplified content workflow with workspaces Active consolidates/reconciles two conflicting core modules and could potentially simplify aspects of trash module too, so that's the current priority in terms of the general area.

  • 🇯🇴Jordan Rajab Natshah Jordan

    Yes, catch, with you.
    The basic line: now, if we install Drupal Core, then add a node in any way, and delete it, it's gone forever (except if it was saved in the last backup).

    We are happy with the current status, it is so nice in Drupal CMS now (Having this space for restoring deleted content) -
    Thanks to the Drupal CMS team for pushing for stable data trash management.
    Moving to adopt this logic in our products.
    I landed on this issue as a part of my research and experimentation to follow up with this logic.

    But it has issues with workflows, workspaces, and autosave.
    As we worked on:

    Noticed the move of logic to workspaces.

    Having these extra fields in the database tables from the starting point of the site could ease many issues with contribs.
    Also, the editorial UX/UI or API CRUD calls for JSON:API endpoints could be safer.

Production build 0.71.5 2024