- Status changed to Needs review
8 months ago 9:51am 28 March 2024 - ๐ท๐ดRomania amateescu
Now that the parent roadmap issue has only one "must-have" issue left, I think it's time to open the review process from core maintainers for this one :)
- ๐ฌ๐งUnited Kingdom catch
I've gone through the entire workspaces queue to look for any hidden blockers as well as the roadmap meta.
#2968165: Finish the Views integration โ means that some listing queries aren't perfectly previewed in workspaces (i.e. if you order by a field that is changed in the current workspace the order is still based on the published revisions), I think this is fine as a should-have given this module can potentially replace the internals of content_moderation and maybe entity form previews in the future, neither of which handle full site preview at all. It won't require any massive refactoring to fix, just applying some existing query alter patterns to more places.
๐ Workspace switcher block does not check access Fixed looked like potential security hardening/protection against mis-configuration, it's already fixed this week.
#3096017: Finalize the Workspaces UI โ doesn't have lots of activity on the issue itself, but @amateescu confirmed the child issues are up-to-date and most of them are completed. There is a navigation initiative issue looking at workspaces, so it may be better to revisit again as part of that too.
There are 43 open issues in total, fairly even split between bugs and tasks. Everything else is in normal bug/task/feature request territory and more likely to be fixed if workspaces picks up more users once it's stable.
I've been reviewing this initiative since it started and also worked on its Drupal 7 predecessors cps and drafty, so confident removing both the release manager and framework manager review tags here.
- ๐บ๐ธUnited States smustgrave
Based on the roadmap seems ๐ Simplify the workspace conflict validator Needs work and โจ Layout builder overrides on a single content item not allowed in stage when using workspaces Needs work are needed.
- ๐ฌ๐งUnited Kingdom catch
@smustgrave yes that's right, #16 assumes those both land before this issue is RTBCed - one just did.
- ๐บ๐ธUnited States smustgrave
Sweet! Pinged @Tim.plunkett about the layout builder as it may be above my head to make that call.
- ๐ญ๐บHungary Gรกbor Hojtsy Hungary
No concerns from core product manager side, removing tag :) Would be great to be able to suggest this amazing feature finally! Further features could be added later to it and/or as contrib modules.
- Status changed to Postponed
8 months ago 2:32pm 29 March 2024 - ๐บ๐ธUnited States smustgrave
Amazing to see this so close! I'm postponing as I've left a comment on โจ Layout builder overrides on a single content item not allowed in stage when using workspaces Needs work if that does need an upgrade path it'll need more work.
- Status changed to RTBC
7 months ago 9:20am 11 April 2024 - ๐ฌ๐งUnited Kingdom catch
The last blocker is in, I think this is ready!
- ๐ญ๐บHungary Gรกbor Hojtsy Hungary
Added a brief release note snippet. I am not aware of things users need to do in order to "move" to the stable module, if they are already using workspaces.
- ๐ฉ๐ชGermany Fabianx
RTBC + 1 - Been using workspaces together with wse in production since a few years on several Enterprise sites.
-
longwave โ
committed 27eda123 on 10.3.x
Issue #3088643 by amateescu, Gรกbor Hojtsy, catch, smustgrave: Mark...
-
longwave โ
committed 27eda123 on 10.3.x
-
longwave โ
committed 42ddeb33 on 11.x
Issue #3088643 by amateescu, Gรกbor Hojtsy, catch, smustgrave: Mark...
-
longwave โ
committed 42ddeb33 on 11.x
- Status changed to Fixed
7 months ago 3:10pm 16 April 2024 - ๐ฌ๐งUnited Kingdom longwave UK
Great work, nice to see this finally over the line.
Committed and pushed 42ddeb3337 to 11.x and 27eda1233b to 10.3.x. Thanks!
๐ Congratulations, what an acheivement! ๐
Based on uses in real scenarios
Could we have more details about this?
I am very curious about realword Drupal project using workspaces.Automatically closed - issue fixed for 2 weeks with no activity.