- Issue created by @malcomio
- First commit to issue fork.
- Merge request !7185Add default access checks for the workspace switcher block. → (Open) created by amateescu
- Status changed to Needs review
10 months ago 7:37am 26 March 2024 - Status changed to Needs work
10 months ago 1:41pm 26 March 2024 - 🇺🇸United States smustgrave
Left some small comments but appears to have failing tests.
- Status changed to Needs review
10 months ago 4:40pm 26 March 2024 - Status changed to Needs work
10 months ago 5:12pm 26 March 2024 - 🇺🇸United States smustgrave
Thanks! Comments appear to be resolved but some workspace functional tests appear to be failing.
- Status changed to Needs review
10 months ago 7:13pm 26 March 2024 - Status changed to RTBC
10 months ago 7:52pm 26 March 2024 - 🇺🇸United States smustgrave
Thanks!
Ran the test-only feature
1) Drupal\Tests\workspaces\Kernel\WorkspaceAccessTest::testWorkspaceSwitcherBlock Failed asserting that true is false. /builds/issue/drupal-3419548/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:121 /builds/issue/drupal-3419548/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:55 /builds/issue/drupal-3419548/core/modules/workspaces/tests/src/Kernel/WorkspaceAccessTest.php:244 /builds/issue/drupal-3419548/vendor/phpunit/phpunit/src/Framework/TestResult.php:728 FAILURES!Shows coverage, but all feedback appears to be addressed. Change looks good!
- Status changed to Fixed
10 months ago 1:14pm 27 March 2024 - 🇬🇧United Kingdom alexpott 🇪🇺🌍
Backporting to 10.2.x as a bug fix.
Committed and pushed bed3a77a89 to 11.x and 34997d05ca to 10.3.x and 0a7cb790b9 to 10.2.x. Thanks!
-
alexpott →
committed 0a7cb790 on 10.2.x
Issue #3419548 by amateescu, smustgrave, malcomio: Workspace switcher...
-
alexpott →
committed 0a7cb790 on 10.2.x
-
alexpott →
committed 34997d05 on 10.3.x
Issue #3419548 by amateescu, smustgrave, malcomio: Workspace switcher...
-
alexpott →
committed 34997d05 on 10.3.x
-
alexpott →
committed bed3a77a on 11.x
Issue #3419548 by amateescu, smustgrave, malcomio: Workspace switcher...
-
alexpott →
committed bed3a77a on 11.x
-
alexpott →
committed e4134bce on 10.2.x
Revert "Issue #3419548 by amateescu, smustgrave, malcomio: Workspace...
-
alexpott →
committed e4134bce on 10.2.x
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
This breaks 10.2.x so it can only go in 10.3.x and up... unless someone re-opens this and creates a new that fixes 10.2.x
Automatically closed - issue fixed for 2 weeks with no activity.