Simplify the workspace conflict validator

@acrazyanimal, a place to store workspace history will be introduced in #2968861: Add a way to revert (undo) a workspace → , it's out of scope for this issue :)

While looking at this patch patch again, I noticed that we need to ensure that WorkspaceAssociation::getEntityTrackingWorkspaceIds() returns workspaces with the most recent revisions first, to cover the case when an entity is edited in a sub-workspace.

Interdiff is to #2, because we can't make the change from #3 in this issue.

Applying the patch tested all the major functionality
Created a workspace
Switched workspaces
Published content

No issue

But don't the changes to the __construct need to be deprecated/trigger_error for backwards compatibility?

Converted the patch to a MR and added explicit test coverage, as requested by @plach in #3091481: Add explicit test coverage for EntityWorkspaceConflictConstraintValidator → .

Added some small nitpicky changes which didn't break anything. Rest of changes appear good though.

Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!

This broke SQLite testing - see https://git.drupalcode.org/project/drupal/-/pipelines/132682/test_report

core/modules/workspaces/tests/src/Functional/WorkspaceEntityDeleteTest.php
core/modules/workspaces/tests/src/Kernel/EntityWorkspaceConflictConstraintValidatorTest.php

Fail

That SQLite test failure was great, it revealed that WorkspaceAssociation::getEntityTrackingWorkspaceIds() was relying on implicit sorting on mysql and postgres. Committed a fix for that.

Seems to have test failures

Fixed that last failure.

That appeared to fix all failures. Thanks!

Committed and pushed d9a1c6e83f to 11.x and da97aa7e11 to 10.3.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.