I updated the branch with latest 3.x but the PHPUnit script is still failing, not sure why.
I fixed that portion of code that was "vanillaed", it seems to be working now.
Passing both now.
Eslint is passing now.
alexpott → credited franz → .
Investigation update:
- I manually changed the langcode in the database for the entries in simplenews_subscriber (all were default language) and simplenews_subscriber__subscriptions (all were 'und') but neither had an effect, all newsletter emails were delivered in default language.
@thejimbirch I'm not sure how requiring stark would help. These block configs are created during site installation. If you look at the link I posted in the description, you'll see that they get duplicated when claro is installed, before its configs are imported. An option to delete configs is certainly useful but in this case it is a workaround. IMO it should be possible to install a theme via recipes with the same outcome as installing manually. Maybe this would require a patch in that code so it doesn't create block copies when installing from recipes? Would certainly be the cleanest way.
franz → created an issue.
I tested this patch and it did work, I now get the missing extension correctly.
Question: for an exception string like this we don't use the plural format?
The project description page links here saying Revisions is a "pending feature" but the ticket was closed 3 years ago. Does it or does it not support revisions?