Add recipes api as experimental API to core

alexpott → credited bircher → .

alexpott → credited deviantintegral → .

alexpott → credited franz → .

alexpott → credited immaculatexavier → .

alexpott → credited narendraR → .

alexpott → credited nedjo → .

alexpott → credited omkar.podey → .

alexpott → credited Rajab Natshah → .

alexpott → credited sonfd → .

alexpott → credited srishtiiee → .

alexpott → credited tasc → .

alexpott → credited thejimbirch → .

alexpott → credited Wim Leers → .

Adding the people who contributed the issues that are committed to the recipe repo as contributors here.

alexpott → credited phenaproxima → .

alexpott → credited vasike → .

Left a review.

You mentioned the other night we could split the APIs up and put them in separately - e.g. the default content api, the config actions stuff.

But reviewing it with gitlab wasn't horrible so I'm not fussed either way.

alexpott → credited amateescu → .

Crediting people of who have been credited in the recipes initiative queue recently.

alexpott → credited millnut → .

Crediting people of who have been credited in the recipes initiative queue recently.

Going to move this to RTBC. All the feedback from @larowlan has been addressed, and out last outstanding issue is being reviewed by @alexpot.

Responded to ~half a dozen threads.

And did a review pass myself too over the parts I had not seen before. Two questions I have:

1. changing InstallCommand looks like a BC break? https://git.drupalcode.org/project/drupal/-/merge_requests/7410#note_306489
2. why do we need all the revision_translation_affected in the default content YAML if it's a read-only field? https://git.drupalcode.org/project/drupal/-/merge_requests/7410#note_306499

Regarding #31.2: it's exported by the default_content module, which is what generates these YAML files. IMHO they should not be changed at this time, but if (which, once this is committed, is really when) core adds the ability to export content entities as YAML, then it may make sense to omit certain fields, like revision_translation_affected.

alexpott → credited longwave → .

Creditting longwave for review

Did a second pass, nothing much to add except some small nits - happy to defer many of them to followups if that helps.

I've addressed/applied @longwave's review - thanks! - great spot on the array_diff. As these were small nits setting back to rtbc.

Some test failures following the change to encode/decode.

Fixed the tests - it was pretty simple so back to RTBC.

Can you please make dataproviders static so we don’t mess up with PHPUnit 10 upgrade ?

Great catch in #40.

Resolved #40 in https://git.drupalcode.org/project/drupal/-/merge_requests/7410/diffs?co... - as this is only about staticness - back to rtbc.

Will need a separate MR for 10.3.x/10.4.x:

CONFLICT (content): Merge conflict in core/lib/Drupal/Core/Command/InstallCommand.php

11.x is also currently frozen but this could be committed there when it's unfrozen and then backported later to 10.4/10.3, so leaving at RTBC for now.

We maintain a 10.3.x version of recipes so that's no problem to push here... which I've done so #43 is done so I guess this can be back to rbtc once we see green on the 10.3.x test run.

we're green on 10.3.x

Thanks to everyone who contributed here, and congratulations on landing this, can't wait to see what we can do in the future now this is available in core.

Committed 74da82a and pushed to 11.x. Thanks!

Committed and pushed 54be1ad9d2 to 10.4.x and a15d5540c6 to 10.3.x. Thanks!

Published the draft CR at https://www.drupal.org/node/3445169 →

longwave → closed merge request !7410

longwave → closed merge request !7908

Automatically closed - issue fixed for 2 weeks with no activity.