🇷🇴Romania @vasike

let's have https://www.drupal.org/project/drupal/issues/3427095 🌱 [Meta] Deprecate text_with_summary Active linked ... at least

Updated the MR - fix tests. made it green

I think this was in "Needs Review"

About the latest comments ... it's NOT only about the body field.... it's a generic solution for all text with summary fields.
Maybe the confusion is from tests ... that uses the already existing body field.

@Emircan Erkul thanks for the issue and patch

2 things

1. 8.1.x is not maintained anymore, you should use/update to 2.0.x
2. Only MRs will be considered, as now we have the gitlab CI
So could you, please, open a MR for 2.0.x ... you could also include other returns types, for the other methods ...

thank you

I tried to address the threads and also applied the suggestions.
Unfortunately I can't run FunctionalJavascript tests locally on 11.x ...
For the other things maybe there will be someone to help here.

there is no sorting ... it's just bad PHP naming flag ... SORT_XXX instead of an explicit ARRAY_ITEMS_COMPARISON_TYPE_XXX flag constant name

not mvp, but good to have .. before some "unique" use cases come around.

vasike → made their first commit to this issue’s fork.

vasike → changed the visibility of the branch 2118743-twig-debug-output to hidden.

alexpott → credited vasike → .

This branch has no future as it's not really D10 compliant and all next devs will going to happen in the new versions ...

@alexpott thanks a lot for the support and guidance and patience.
and for solution

i think it's RTBC

it will fail the recipe tests .. sorry

@alexpott simplified as much as I could. I hope it's ok.

MR updated withe extra methods for overriding

Is it too much?

I thought maybe there could be other image styles for standard_responsive_images

I would say there could be positive things like do not run module installer and rebuildContainer if not needed
and maybe it could help with others todo in StandardRecipeTest

but we'll see

What i could find here was to "hack" a little \Drupal\Tests\standard\Functional\StandardTest
Not sure how "hacky" it is ... but maybe will help to find cleanest solution to share the test code between Standard profile and recipe.

vasike → made their first commit to this issue’s fork.

vasike → changed the visibility of the branch 2916876-10.1.x to hidden.

I updated the MR
- Revert BlockVisibilityForm to ajax button version as tests expected
- And some cleanup

So, we should have an 11.x MR working ... which should be used for the solution

Also hiding all the patches. We should work only on the current MR.

Unfortunately the mix of patches (mostly without interdiff) and MRs "slowed down" the progress here ... imho

It seems the gitlab it's back in business.
But the latest MR for 10.x got "dirty" from the mix of patches and MR updates attempt ... this means also the new 11.x MR is not in the "best shape".
So for start we need to review again all the updates and put it back on track.

vasike → changed the visibility of the branch 2916876-ajax-condition-form to hidden.

vasike → changed the visibility of the branch 2916876-add-visibility-control to hidden.

vasike → changed the visibility of the branch 2916876-add-visibility-control-9-5 to hidden.

vasike → changed the visibility of the branch 2916876-11.x to hidden.

vasike → changed the visibility of the branch 2916876-add-visibility-control-11.x to active.

Summary updated.

I created new branch for 11.x as the previous one seems not clean enough ... it contains other commits ...
https://git.drupalcode.org/issue/drupal-2916876/-/tree/2916876-add-visib...

Also included some fixes for CS, PHPStan, CSS ...

However it seems the drupal gitlab doesn't like this branch
There are issues creatina and running pipelines and also latest failed to create new MR
https://git.drupalcode.org/project/drupal/-/merge_requests/7501

I'm putting on Needs Review as the MR should be (created and ) Green.

MR available. I hope i didn't miss anything

vasike → made their first commit to this issue’s fork.

@longwave thank you for the "guidance"
Also @SoulReceiver comments helped.
i remembered some things about this issue.

indeed the previous tests added tried for the related issue which actually solved this specific case when we have multiple "Has taxonomy term" filters.
And this multiple uses will bring "LEFT JOIN" from the second filter .. which means the tests will pass anyway.

The trick ... having the second taxonomy filter as "field filter". It still uses the "taxonomy_index_tid" filter plugin so, I think we're still in the right place and (+) it adds and extra test for taxonomy fields.
Also removed some tests that weren't that relevant here.

https://git.drupalcode.org/issue/drupal-1766338/-/jobs/1304700

I'm more than aware it's not the perfect/complete solution for the fix ... but at least it could save the day.
To save the (Views Filter Grouping) Universe ... I think another issue is needed ... starting maybe with some kernel tests about those FIlters GROUPING JOINS.

p.s. Views and tests needs a lot of efforts ... still

It seems the changes for this issue were not included in the related issue commits.

So i re-opened the MR and added the tests code from there.
i think we are back to review.

hestenet → credited vasike → .

and no more EsLint errors or warnings

vasike → created an issue.

ended by merging both of MRs ... it happens
now it can be used in D11 ...

solution now in 2.x version
queue clean-up

queue clean-up

edge case
queue clean-up

answer provided ....
queue clean-up

queue clean-up

Duplicate Views known issue ...
queue clean-up

queue clean-up

new MR https://git.drupalcode.org/project/views_autocomplete_filters/-/merge_re... available

The automated patch needs a little clean up. Drupal version should start with 10 ...

there is no solution

indeed ... missed to include the change in the previous commit

MR threads addressed.

it seems we need to hide the patch from #185
back to previous Status ... RTBC

and it's dome ... we have a logo.

- Logo created
- Logo added to the project page
- MR available.

vasike → created an issue.

Tests added that covers this ... so we should be covered.
+ New release which includes this ... so Fixed.

MR passed and merged
+ Added follow-up issue https://www.drupal.org/project/views_autocomplete_filters/issues/3430426 📌 Complete module tests Active

I think we can close it.

vasike → created an issue.

MR available

Implement ViewsAutocompleteFiltersTest Functional Javascript tests,
trying to cover all (usual) possible cases, except "Allow Contextual filters to apply to this filter" option,
As I'm not sure how to replicate the solution from https://www.drupal.org/project/views_autocomplete_filters/issues/3259438 ✨ Not working with contextual filters Fixed .

No Kernel or Functional tests ... maybe in a follow-up.

vasike → created an issue.

MR green again

Also I hid the latest patch ... needs-review-queue-bot doesn't like it https://www.drupal.org/files/issues/2024-03-14/3347343-nr-bot.txt →

MR updated - solved conflicts
so RTBC ... once more

Solved conflicts and also new CS issues
However it seems there are other things going on for CI
As the new Validatable config job ... which, of course it fails

Probably this should be covered by a child issue
https://www.drupal.org/project/drupal/issues/2869792 🌱 [meta] Add constraints to all config entity types Active
... which seems ... missing
"Not ideal ... to be polite"

I put the issue for Review ... just to gain some attention
As the feeling is that it could become stalled ... as original ... for other years.

p.s. also linked those issues ... maybe there we could have more awareness

I would make duplicate of https://www.drupal.org/project/views_autocomplete_filters/issues/3393550 ✨ Bug when using contrib module Realname Needs work
As i think we could join forces to have something that could be used to integrate with other modules.

And we could add there examples for this case in hooks api file.

and MR merged ... now the autosubmit should be available in the latest dev version

composer require 'drupal/views_autocomplete_filters:2.0.x-dev@dev'

Leave the issue in Needs review - for now - to get some feedback for the "results".

thanks to all for the efforts on this.

MR available - created from previous patches ... thanks to all
+ some small updates and made it green.

And merged ... i think now there is a solution for contextual filters
Many thanks to @venugopp and @Jeff Cardwell.

closing - queue clean-up.

MR available ... from previous patches ... thanks.

It's a known issue if we have duplicate values.

I'm afraid the patches here could not be considered here.
As it's not desired to make a query for "millions" of results ... which actually is possible if the limit is empty.
But if someone decides a limit is needed ... then query limit is desired.

However we could:
- Add info to project about this https://www.drupal.org/project/views_autocomplete_filters/issues/3387912... 🌱 Module Documentation and infos Active
- And maybe try to have this altering solution ... maybe it could help in such cases
https://www.drupal.org/project/views_autocomplete_filters/issues/3393550 ✨ Bug when using contrib module Realname Needs work

This looks (quite) outdated.

update version ... and waiting for core

i can't replicate this ...i tried (even) with ajax enabled and Paragraphs ... no errors

of course with the "current" Drupal (10.2) and latest dev version of the module.

so I\m closing for now ... as clean-up queue.
Please feel free to re-open if "it's the case".

Also added the Drupal core issue mentioned here ... which "sounds" like duplicate.

this sounds like an "edge case" ... more info and examples and participants could help here.

just updating the issue - not to be "lost again" ... clean-up queue.

i would wait for core solution first - clean-up queue.

still not clear here. maybe someone could add new feedback here.

could be related with https://www.drupal.org/project/views_autocomplete_filters/issues/3117099 📌 Incompatibility with search autocomplete module Fixed ?

This module does not provide "text processors" ... so this is out of scope.

BUT, this could be achieved with Search API → Views for SearchApiFulltext filters.

a quick search for "drupal search api views"

is it still happen witth the latest version?

I don't think "it caches"
https://git.drupalcode.org/project/views_autocomplete_filters/-/blob/2.0...

and merged
thanks a lot @Manuel Garcia ... sorry for delay ;)

MR created.

it seems the core issue was "done" some time ago ... so maybe we could clean-up here.

update the branch and I'll create a MR as the patch doesn't apply anymore.

It needs Drupal Views Link Url property field implementation - which is out of scope for this module
However keep it here as maybe someone will provide some info.
... cleanup the queue.

This looks like duplicate of
https://www.drupal.org/project/views_autocomplete_filters/issues/3259438 ✨ Not working with contextual filters Fixed

... cleanup the queue.

I think we still need something done in core ... cleanup the queue.

I couldn't reproduced - cleanup the queue.

version update

closing as there were no new valuable info added and it couldn't be reproduced.
+ cleanup the queue.

I think this should be part of https://www.drupal.org/project/views_autocomplete_filters/issues/3259438 ✨ Not working with contextual filters Fixed

So closing as "duplicate" - cleanup the queue.

- Add related issue
- Update the version
- Update category ... it's a feature request.
- And postponed ... till the related issue has a solution.

closing as there were no new valuable info added and it couldn't be reproduced.

closing ...

And the page was updated https://www.drupal.org/project/views_autocomplete_filters →

vasike → created an issue.

CSpell green (passed) - MR merged

MR available

vasike → created an issue.