🇷🇴Romania @vasike

MR updated with latest 11.x + some feedback for MR review.

Let's try again a review. thanks

Updated the MR with latest 11.x: solving conflicts and Fix test according with field ui API updates - issue #3386762 ✨ Use modal in add new field flow Active .

Updated the MR with latest 11.x: solving conflicts and Fix test according with field ui API updates - issue #3386762 ✨ Use modal in add new field flow Active .

no feedback ... consider fixed .... closing

@g4mbini

the documentation is wrong there ... actually the content ... it's about the drawer content - as Open Drawer text, please check the examples
It's not about the page content

<div class="drawer">
  <input id="my-drawer" type="checkbox" class="drawer-toggle" />
  <div class="drawer-content">
    <!-- Page content here -->
    <label for="my-drawer" class="btn btn-primary drawer-button">Open drawer</label>
  </div>
  <div class="drawer-side">
    <label for="my-drawer" aria-label="close sidebar" class="drawer-overlay"></label>
    <ul class="menu bg-base-200 text-base-content min-h-full w-80 p-4">
      <!-- Sidebar content here -->
      <li><a>Sidebar Item 1</a></li>
      <li><a>Sidebar Item 2</a></li>
    </ul>
  </div>
</div>

Here is an example I tried for a project.
Using an hamburger svg for the drawer and the entire header region.
Without duplicate the "menus" code for responsive ...

<div class="navbar-end gap-4">

      <div class="drawer lg:drawer-open w-auto">
        <input id="nav-drawer" type="checkbox" class="drawer-toggle" />
        <div class="drawer-content flex-none lg:hidden">
          <label for="nav-drawer" aria-label="open sidebar" class="btn btn-ghost">
            <svg
              xmlns="http://www.w3.org/2000/svg"
              fill="none"
              viewBox="0 0 24 24"
              class="inline-block h-6 w-6 stroke-current">
              <path
                stroke-linecap="round"
                stroke-linejoin="round"
                stroke-width="2"
                d="M4 6h16M4 12h16M4 18h16"></path>
            </svg>
          </label>
        </div>
        <div class="drawer-side lg:relative lg:h-auto z-1500">
          <label for="nav-drawer" aria-label="close sidebar" class="drawer-overlay"></label>
          <div class="bg-base-200 min-h-full w-full md:w-auto md:min-w-1/3  p-4 flex flex-col items-center justify-center">
            <label for="nav-drawer" aria-label="close sidebar" class="lg:hidden p-5 p-t-20 p-r-20 w-full text-center bold cursor-pointer">x</label>
            {% block header %}
              {{ header }}
            {% endblock %}
          </div>
        </div>
      </div>

    </div>

So, imho, this could be a good candidate for better navbar component also for this theme/project...

As Drupal 7.x and also modules 7.x versions "ended their lives", closing the 7.x issues.

And thanks for participating and using the module.

p.s. if this still an issue on the latest 2.x version, please feel free to re-open and update the version accordingly.

p.s.2. I know it's a S issue ... but ...

As Drupal 7.x and also modules 7.x versions "ended their lives", closing the 7.x issues.

And thanks for participating and using the module.

p.s. if this still an issue on the latest 2.x version, please feel free to re-open and update the version accordingly.

As Drupal 7.x and also modules 7.x versions "ended their lives", closing the 7.x issues.

And thanks for participating and using the module.

p.s. if this still an issue on the latest 2.x version, please feel free to re-open and update the version accordingly.

As Drupal 7.x and also modules 7.x versions "ended their lives", closing the 7.x issues.

And thanks for participating and using the module.

p.s. if this still an issue on the latest 2.x version, please feel free to re-open and update the version accordingly.

As Drupal 7.x and also modules 7.x versions "ended their lives", closing the 7.x issues.

And thanks for participating and using the module.

p.s. if this still an issue on the latest 2.x version, please feel free to re-open and update the version accordingly.

As Drupal 7.x and also modules 7.x versions "ended their lives", closing the 7.x issues.

And thanks for participating and using the module.

p.s. if this still an issue on the latest 2.x version, please feel free to re-open and update the version accordingly.

As Drupal 7.x and also modules 7.x versions "ended their lives", closing the 7.x issues.

And thanks for participating and using the module.

p.s. if this still an issue on the latest 2.x version, please feel free to re-open and update the version accordingly.

As Drupal 7.x and also modules 7.x versions "ended their lives", closing the 7.x issues.

And thanks for participating and using the module.

p.s. if this still an issue on the latest 2.x version, please feel free to re-open and update the version accordingly.

As Drupal 7.x and also modules 7.x versions "ended their lives", closing the 7.x issues.

And thanks for participating and using the module.

p.s. if this still an issue on the latest 2.x version, please feel free to re-open and update the version accordingly.

As Drupal 7.x and also modules 7.x versions "ended their lives", closing the 7.x issues.

And thanks for participating and using the module.

p.s. if this still an issue on the latest 2.x version, please feel free to re-open and update the version accordingly.

As Drupal 7.x and also modules 7.x versions "ended their lives", closing the 7.x issues.

And thanks for participating and using the module.

p.s. if this still an issue on the latest 2.x version, please feel free to re-open and update the version accordingly.

As Drupal 7.x and also modules 7.x versions "ended their lives", closing the 7.x issues.

And thanks for participating and using the module.

p.s. if this still an issue on the latest 2.x version, please feel free to re-open and update the version accordingly.

As Drupal 7.x and also modules 7.x versions "ended their lives", closing the 7.x issues.

And thanks for participating and using the module.

p.s. if this still an issue on the latest 2.x version, please feel free to re-open and update the version accordingly.

As Drupal 7.x and also modules 7.x versions "ended their lives", closing the 7.x issues.

And thanks for participating and using the module.

p.s. if this still an issue on the latest 2.x version, please feel free to re-open and update the version accordingly.

As Drupal 7.x and also modules 7.x versions "ended their lives", closing the 7.x issues.

And thanks for participating and using the module.

p.s. if this still an issue on the latest 2.x version, please feel free to re-open and update the version accordingly.

As Drupal 7.x and also modules 7.x versions "ended their lives", closing the 7.x issues.

And thanks for participating and using the module.

p.s. if this still an issue on the latest 2.x version, please feel free to re-open and update the version accordingly.

As Drupal 7.x and also modules 7.x versions "ended their lives", closing the 7.x issues.

And thanks for participating and using the module.

p.s. if this still an issue on the latest 2.x version, please feel free to re-open and update the version accordingly.

As Drupal 7.x and also modules 7.x versions "ended their lives", closing the 7.x issues.

And thanks for participating and using the module.

p.s. if this still an issue on the latest 2.x version, please feel free to re-open and update the version accordingly.

As Drupal 7.x and also modules 7.x versions "ended their lives", closing the 7.x issues.

And thanks for participating and using the module.

p.s. if this still an issue on the latest 2.x version, please feel free to re-open and update the version accordingly.

As Drupal 7.x and also modules 7.x versions "ended their lives", closing the 7.x issues.

And thanks for participating and using the module.

p.s. if this still an issue on the latest 2.x version, please feel free to re-open and update the version accordingly.

As Drupal 7.x and also modules 7.x versions "ended their lives", closing the 7.x issues.

And thanks for participating and using the module.

p.s. if this still an issue on the latest 2.x version, please feel free to re-open and update the version accordingly.

As Drupal 7.x and also modules 7.x versions "ended their lives", closing the 7.x issues.

And thanks for participating and using the module.

p.s. if this still an issue on the latest 2.x version, please feel free to re-open and update the version accordingly.

As Drupal 7.x and also modules 7.x versions "ended their lives", closing the 7.x issues.

And thanks for participating and using the module.

p.s. if this still an issue on the latest 2.x version, please feel free to re-open and update the version accordingly.

As Drupal 7.x and also modules 7.x versions "ended their lives", closing the 7.x issues.

And thanks for participating and using the module.

p.s. if this still an issue on the latest 2.x version, please feel free to re-open and update the version accordingly.

As Drupal 7.x and also modules 7.x versions "ended their lives", closing the 7.x issues.

And thanks for participating and using the module.

p.s. if this still an issue on the latest 2.x version, please feel free to re-open and update the version accordingly.

As Drupal 7.x and also modules 7.x versions "ended their lives", closing the 7.x issues.

And thanks for participating and using the module.

p.s. if this still an issue on the latest 2.x version, please feel free to re-open and update the version accordingly.

As Drupal 7.x and also modules 7.x versions "ended their lives", closing the 7.x issues.

And thanks for participating and using the module.

p.s. if this still an issue on the latest 2.x version, please feel free to re-open and update the version accordingly.

As Drupal 7.x and also modules 7.x versions "ended their lives", closing the 7.x issues.

And thanks for participating and using the module.

p.s. if this still an issue on the latest 2.x version, please feel free to re-open and update the version accordingly.

As Drupal 7.x and also modules 7.x versions "ended their lives", closing the 7.x issues.

And thanks for participating and using the module.

p.s. if this still an issue on the latest 2.x version, please feel free to re-open and update the version accordingly.

As Drupal 7.x and also modules 7.x versions "ended their lives", closing the 7.x issues.

And thanks for participating and using the module.

p.s. if this still an issue on the latest 2.x version, please feel free to re-open and update the version accordingly.

As Drupal 7.x and also modules 7.x versions "ended their lives", closing the 7.x issues.

And thanks for participating and using the module.

p.s. if this still an issue on the latest 2.x version, please feel free to re-open and update the version accordingly.

As Drupal 7.x and also modules 7.x versions "ended their lives", closing the 7.x issues.

And thanks for participating and using the module.

As Drupal 7.x and also modules 7.x versions "ended their lives", closing the 7.x issues.

And thanks for participating and using the module.

As Drupal 7.x and also modules 7.x versions "ended their lives", closing the 7.x issues.

And thanks for participating and using the module.

sorry to re-open this issue, but I totally agree with @anybody, so @pdureau, please update the project page with this very useful comparison
info.

and thanks a lot.

This feature looks covered by another module - https://www.drupal.org/project/colorbox_media_video →
But I agree it would be nice to have it here ... So maybe a combination of existing MR solution with the module solution would be best.

MR threads addressed ... so back to review.

MR threads addressed/closed + CR Draft created ... so back to review.

This is not only for AI, nor only for ECA, nor only for VBO, nor only with Action UI
It's just an action/config that could be used for various Multilingual cases using the Core Recipes approach.
Let's say for Drupal CMS Multilingual CMS.
Or For a Multilingual recipe, that does not need any of other contrib modules, as maybe there are other specific custom modules to help with this action.
If we move this to any of AI, ECA, VBO or other ... then the need of such Action/Config will require extra dependencies and this is not specific to these modules.
For me, it's just Drupal Core ... but maybe I'm too "subjective".

@szantog thanks for the issue and the proposal MR

I'm not sure about this issue is really a bug.
So first thing: did you try your View(s) with autocomplete_contextual (Allow Contextual filters to apply to this filter label) option selected for your Autocomplete filters?
This option is disabled by the default, as it was introduced at the later stage, when this kind of issues needed to be covered.

If this "hint" still do not solve this issue case, this mean we need a new feature to cover ...

For now i'll change the issue type and status ... to get the "new results" first.

Second: this module has tests (Gitlab CI/CD pipeline) for while, so this means whatever MR is proposed, it needs to be Green all Gitlab CI/CD pipelines should pass - before "Needs review" status.
Other wise, it means the solution/isssue "Needs work".

I confirm this an issue not from this module ... but custom twig template issue

Besides the Views case ... it seems there could be also a case for Fields templates.
maybe it helps other people.

So, similar with #20 solution, for fields, please check the items usage

    {% for item in items %}
      <div{{ item.attributes.addClass('whatever-class') }}>{{ item.content }}</div>
    {% endfor %}

instead of

    {% for item in items %}
      <div>{{ item }}</div>
    {% endfor %}

@shelane I think you could close this as won't fix or works as designed ... as it's not about this module.
however I put it on Needs Review for now, just for ... action ... closing.

MR created, so Needs Review

question: Could the _utilities.scss be emptied?

is this used anywhere?

    ("columns": (property: columns,
        class: columns,
        responsive: true,
        values: (2: 2,
          3: 3,
          4: 4,
          5: 5,
          auto: auto,
        ),
      ),

what should it do/solve?

vasike → created an issue.

new MR available
https://git.drupalcode.org/project/ui_suite_daisyui/-/merge_requests/140

Which updates the previous one:
- Use the daisyUI logo/icon
- Delete the extra files that "needed renaming" - not actually needed
- Fix the Regions and libraries
- Remove not needed files ... empty or inherited from the base theme.
- Emptied generated CSS file.
- Update README file - simplify the process + remove older Drupal info.

I could generate an working theme just with

php core/scripts/drupal generate-theme my_daisyui_theme --starterkit ui_suite_daisyui_starterkit --path themes/custom
npm install
npm run build or npm run dev

commands

vasike → made their first commit to this issue’s fork.

solving bot patching issue ... MR updated with latest 11.x

Created a MR with new uid option for import only using the account_switcher service.

I tested within a project doing Migrate Source CSV dependant migration imports, using ECA Models to control different entities data.
And it worked as expected.
Needs review ... for now ... to get some feedback.
Do we need also for other "commands"?

Note: For ECA models "alteration" this could also achieved, but currently the option is to have the user set for all models ...

Also it seems the issue was previously for an older version, so initially I created a "bad" branch
which seems I can't delete it
https://git.drupalcode.org/issue/migrate_tools-3134245/-/tree/3134245-ru...

vasike → changed the visibility of the branch 3134245-run-drush-imports-uid-option to hidden.

vasike → made their first commit to this issue’s fork.

@daniele.chiminelli Could you please, make sure you have also the relationship set for the Title field to be displayed.
Maybe you need to Add new Title field just for this relationship ...

This module it uses its own fields set.

it should work ... imho.

This could achieved with the "proposal" from https://www.drupal.org/project/drupal/issues/3506152 ✨ Translate Action for Content Translation module Active

@jurgenhaas already checked ... but more tests and feedback could help.

Added as related issue.

This could achieved with the "proposal" from https://www.drupal.org/project/drupal/issues/3509597 ✨ Image Style Action plugin for image files Active

Of course make sure the Image Style uses imageapi_optimize ... properly.

Added as related issue.

This could achieved with the "proposal" from https://www.drupal.org/project/drupal/issues/3509597 ✨ Image Style Action plugin for image files Active

Added as related issue.

Updates on the MR and issue summary ... support for generate Derivatives ...

p.s. there could be issues for action access because of file access issues like
https://www.drupal.org/project/drupal/issues/3450005 🐛 File entity update is allowed only for user who has uploaded the file Active

MR available - first attempt

For start:
- What's not clear?
- What's missing?
- Naming (for classes/action) - this big one topic
- What's next

vasike → created an issue.

@sgourebi and it's merged

however, I couldn't replicate this, even tried to include in testing ... but no luck ...
but as I said, it won't hurt and it's good to have.

thanks a lot.

p.s. please "do not RTBC your own solutions" ... as a practice/habit ...

it seems there were some tests in an issue patch by @quietone (#59)

And I applied (partially) and cleaned up ... the hook removed as it has already tests + I don't think the hooks should return "values".

However, now it seems the MR has a failure which I don't think it's related.
And I can't replicate locally.

So the MR (#74 approach) works and solve this kind of issues.

However, I did pushed some updates for fixing the tests ... And those updates indicates the solution do not seem right or complete, at least.
interfering with exception MigrateSkipRowException->saveToMap

Then I reverted those changes and "extended" SourcePluginBase with a new property to be aware of saveToMap and to have control for "non-saving cases".

Now we should add proper tests for this issue/solution cases.
Of course if this trick would be considered "OK".

Temporary on Needs Review

vasike → made their first commit to this issue’s fork.

MR Updates:
- Align with latest 11.x - solve conflicts
- MR review - suggestions updates.
- MR Review - OOP hook update.

For now ... on Needs Review

Should we put it back on RTBC, instead?

vasike → made their first commit to this issue’s fork.

@berdir thanks a lot for your thoughts, but, please, allow me to disagree
We have in core:
- Add/Create Translation API - but no Action for it
- There is hook for this - updated the MR with testing on it.

This "proposal" is using mostly Core API, except the translation source thing, which seems that needs Content Translation module

My question
Do we want "CTools/Entity API" approaches, not to mention things like CCK/Views/i18n and related "era"
So, imho, the core should provide CORE solutions for its API, not to have, again, extra modules to "complete" a basic Drupal project.

@sgourebi thanks a lot for reporting this and also for the MR and patch.
The code definitely won't hurt and it's good to have.
Even I can't replicate it.

However, some questions/things:
1. Why 2.0.0 version? and not latest?
2. How could you "achieve" this? Is it about an old View - updated/re-edited?
3. Once you have solution please change the status of issue, so other people know to check that solution.
4. If you won't work on the solution/issue, please "un-assign" the issue

Thanks again

p.s. I updated the status, accordingly ...

I put as Fixed, and not duplicate as @the_glitch code looks similar with the solution and it was about the same time with the other issue solutions.
So credits also to @the_glitch ...

actually this is already in and it's a duplicate https://www.drupal.org/project/views_autocomplete_filters/issues/1724278 ✨ Submit query on selection Fixed

even the code seems similar ... if not the same

Gitlab CI said OK ... also some local testing ... merged -> fixed.

and there is the MR ... Green

@dieterholvoet thanks man and sorry
... I was sure i merged this one ... as I solved the conflicts ... after my other updates.

probably I got lost ... chasing several issues and MRs and commits and so on ... as it seems the module needed some updates/attention.
and all because of your MR that revealed there are issues.

now it should be merged/fixed.

thanks again

vasike → created an issue.

could we update this issue with more details, starting with title, issue summary ... also some screenshot, I think, would help here.

added the tags for this.

@emircan erkul thanks a lot for point this out and for the MR

I think this was covered by the updates
https://www.drupal.org/project/views_autocomplete_filters/issues/3507732 📌 Updates on GitLab CI and Fix any issues Active
and MRs became empty ... so closing

and it's merged ... cleaner code ... at least.

and it's merged ... cleaner code ... at least.

Mr available and "green"

vasike → created an issue.

the MR looks right ... but the module has tests ... this mean a new feature, or just an issue code solution should be covered also by tests

@max-kuzomko Could you, please, provide more details?
Is it about having multiple Views in the same page with Exposed Filters and Autocompletes?

indeed, we need first the Green back for the the MRs ...

@dieterholvoet Thanks a lot and maybe you could also check the related issue and solved the tests.

closing this.

vasike → made their first commit to this issue’s fork.

And we have MR ... which passed and it was merged into dev ...
So we can move forward with other MRs/efforts/issues.

Updates on MR:
- Fix Dependent filters js error - old/bad code
- CleanUp Dependent filters js - use existing core/misc/autocomplete.js - not duplicate all of them if it's not custom - for better maintainability
- Rename Dependent filters and Autosubmit libraries and js to work with latest Drupal Core.
This was/is the most tricky part ... There are changes in Core about Optimize the usage of libraries, their dependencies and even order (weights)
As the weights will be deprecated in the next Drupal versions
I used the naming for controlling the order:

Js files re-naming

j
s/views-autocomplete-filters-dependent.js → js/1-dependent.js 
js/views-autocomplete-filters-autosubmit.js → js/2-autosubmit.js

Libraries renaming

drupal.views-autocomplete-filters-dependent → 1-dependent
drupal.views-autocomplete-filters-autosubmit → 2-autosubmit

I'll keep this issue open for a while, as there could be more things to be done?
Maybe
- there are still issues, or some new
- Change Records for the changes - if needed.

After some investigations it seems the issues are related with the custom js libraries for Dependent filters and Autosubmit options.
And it's not only the tests, they're broken in the "real world"

I'll try to update the issue info with the discoveries.

vasike → created an issue.

@berdir initially I was using CreateTranslationAction as naming ... maybe it's closer to the "truth"
But then I thought on other cases/options ... for example "Reset" Translation if exists, ro use the source to override/start over the translation.

I mentioned in my first comment some "topics", including naming/missing/follow-ups

For now I updated the title and the summary "terminology" ... not to confuse people, there will be translated content - ready to use/publish.

@smustgrave it's not the same ... it should be clear from issue summary - User interface changes section
So this is about missing those options ... the other issue it's about their actually filtering ...

Anyway updated the MR with latest 11.x and also checked the tests ... they fail without the fix.

So I think this should be back on track.

oh ... this is much more than outdated ... ancient