Editing Action generates two errors

Sorry for being new here. Patch #15 works for us with the minor caveat that for Drupal 10.2.4 with PHP 8.1.27 I get the following two variables need to be typed, likely due to when this patch was originally made.

public string $value_value;
public ?array $valueOptions;

After applying the patch I can use actions and bulk assign domains via /admin/content

Is this issue still relevant in 2.0 branch? It is recommended to use latest beta 2.0 release and new patches against latest 2.0-dev since branch 8.x is not supported no more.

@dqd yes, it still applies to 2.0-dev

Thanks @eswiderski good to now.

#22 @cpocket: Thanks for the review.

I get the following two variables need to be typed, likely due to when this patch was originally made.

public string $value_value;
public ?array $valueOptions;

I think this is related to: 🐛 DomainAccessCurrentAllFilter missing variable type inheritance Needs work and would be fixed there. I would encourage to commit the other first and then try to reroll this one here to be committed afterwards.

Here's a naive re-roll of #15 against 2.0.x. Needed it urgently to keep an ECA rule working.

This is still a valid issue
So I created a MR using the latest (re-rolled) patch (#26) and then solve some PHPCS and PHPStan small issues to make it green.

This also solve a (smaller) related issue : https://www.drupal.org/project/domain/issues/3478258 💬 Undefined array key "id" Domain Access Active

For me, the latest patch, is more like RTBC as it works for me and probably also @dubois ...

But let's review and test once again.

p.s. Probably we need also let people know they need to re-export the updated configs.

Both the patch and MR diff worked for me once I updated to 2.0.x-dev.
Note these will not apply to latest release 2.0.0-beta2

Update hooks 8002, 8003 ran successfully.

Code review as well in MR looks good @vasike.

Not sure what to test here at this point, but at least I didn't see any issues when updating my 2.0.x version and applying the MR.

But I did see one error which I don't think it is related with this and I'll create a separate issue for that (found a PHP deprecation issue in the DomainConfigUIManager.php file).

I'll move this to RTBC

Thanks for MR, @vasike and review others. Switched to using MR on sites and no issues thus far.

Could we merge this to the 2.0.x branch @mably ? What do you think?

@danrod how are we supposed to test this?