Node Type / Entity bundle conditions evaluation is wrong when context is not provided

- Rebase the MR
- Update - Small test for missing context for EntityBundle condition - without this update will fail.

It seems the latest updates revealed issue with testing the block with node bundle condition - missing route context ...
Now it should be "completed".

Seems tests have been added but IS update is still needed

Did not test yet.

updatet summary and MR rebased.

11.x is the latest development branch. MR should probably be updated to point to that.

Ran the tests locally to make sure they failed without the fix

Behat\Mink\Exception\ElementNotFoundException : Form field with id|name|label|value "visibility[entity_bundle:node][context_mapping][node]" not found.

and

Drupal\Component\Plugin\Exception\ContextException : The 'entity:entity_test_with_bundle' context is required and not present.

Which is good

Thanks for updating the issue summary, removing that tag

Think this 7 year issue is ready for committer review.

Doing RTBC triage.

The issue summary is up to date and I see that a remaining task is 'code review'.

The issue title was changed on GitLab but that is not reflected here. Can someone fix that?

Reading through the comments there is work on the patch, addition of tests and rerolls but there is no code review that I can find. I do see that @smustgrave ran a fail test locally, that is good to know. But still in need of eyes on the code.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

new MR for 11.x available and passed, so, i think we're back to Needs review

All green for 11.x so think this is good to go back.

There are two open merge requests in the issue summary. Please close the non-canonical one, or if you don't have permission to close it, document which should be closed in an issue comment and the IS so a committer can close it for you.

Updated proposed section

Thanks @smustgrave. I think maybe we should put in at least an h4 for this, or possibly add it under a separate h3, so that it's obvious on scanning. I updated the summary accordingly.

xjm → closed merge request !2879

Posted some comments on the MR. I'd also like to see some manual testing documented for node and non-node entity bundles. Thanks!

Attached is a snapshot of the current state of MR 4610, so it can be safely used with composer-patches.

I came across this issue through ✨ Add support for negating node type(content type) condition for block visibility Needs work , which seems to work in combination with MR 4610.

However, I've tried to test MR 4610 standalone, but I'm not sure what it should resolve. If I understand this issue correctly the MR should resolve the fact that blocks are hidden on non-node-type routes when there is a node bundle condition configured. I've add a condition for "Article" nodes to the page title block, visited a non existent page so I could see the 404 page but the page title was still hidden.

oily → changed the visibility of the branch 11.x to hidden.

Edited the issue summary. Simplified the description and steps to reproduce and remove duplicate sections.

Rebased.

There are still code comments to be resolved in the MR especially in the tests. The issue tags show other tasks to be completed.