🇬🇧United Kingdom @millnut

finn lewis → credited millnut → .

markconroy → credited millnut → .

millnut → created an issue.

Minor credit :) just flagged that we should use 2.x vs 1.x so we gain D11 support

finn lewis → credited millnut → .

I was there, great content

I attended

Thanks @johnv for fixing this

Hi @johnv I guess there are two ways to approach this;

1. revert the types on constants

e.g.

public const string UPDATE = 'office_hours.update';

for < PHP 8.3 this would work
public const UPDATE = 'office_hours.update';

2. add a php composer requirement in composer.json to the next release, so if users are running < PHP 8.3, the module won't upgrade unless the requirements are met

"require": {
    "php": ">=8.3.0"
},

finn lewis → credited millnut → .

Hi, this breaks when running the module in PHP 8.1 and PHP 8.2.

Constant visibility modifiers have existed since 7.1, however typed constants were only introduced in PHP 8.3 and later https://php.watch/versions/8.3/typed-constants

millnut → made their first commit to this issue’s fork.

finn lewis → credited millnut → .

RTBC +1, would be good to get a tagged release as this is the only module preventing me from updating to D11

finn lewis → credited millnut → .

I don't think the MR attached to this solves the issue it just has renamed the function to match the deprecation.

At the moment this causes issues with our deployment (currently ignoring) due to the deprecation error and saying to use "findEntityUrl" which doesn't appear to exist

millnut → created an issue.

millnut → created an issue.

alexpott → credited millnut → .

Uploaded my `cex` export for the minimal site I'm testing against

Yep so the WYWIWYG text format gets installed by the localgov_media module under "config/optional", which is a submodule of the localgov_core module.

I tested this under a minimal profile so no existing WYSIWYG text format, I'll generate a full config export later today

millnut → changed the visibility of the branch 3408100-add-gitlab-ci to active.

millnut → changed the visibility of the branch 3408100-add-gitlab-ci to hidden.

Yeah no problem I've just committed the code back into the main branch here which breaks the recipe apply with the error above https://github.com/millnut/localgov_recipe

millnut → created an issue.

This should be good to merge and fix the gitlab-ci errors

millnut → changed the visibility of the branch 3413221-update-gitlab-ci-file to active.

millnut → changed the visibility of the branch 3413221-update-gitlab-ci-file to hidden.

millnut → created an issue.

Works for me also, would be good to get a tagged release with this in

Just to update we are also seeing unexpected results when setting permissions in the UI, more context here https://github.com/localgovdrupal/localgov_microsites_group/issues/427#i....

@LOBsTerr do you have any ideas on this?

Ready for review; phpcs fails due to coding standards issues; and similar warning for eslint but that is currently set to warning only.

Changed to "Active" as I want to look into getting a matrix setup to test against both PHP 8.1 and 8.2 and hard fail coding standards so it matches the github workflow.

Ignore composer require failures, I didn't realise that is from DrupalCI manual runs. The GitLab CI pipeline passes with warnings on phpcs and eslint.

Those warnings I can pick up once the gitlabci file is merged in.

millnut → created an issue.

millnut → created an issue.

millnut → created an issue.

Confirming this patch 16 fixes my issue in Drupal 9.5.x, with the minimal test case below.

- Creating new content
- Required Date field in a paragraph with no default value set
- Using media library for an image field

Results in an AJAX error and the media library popup not opening

We've just hit this doing an upgrade from Drupal 9.5 to Drupal 10 where deprecated hooks are not flagged in upgrade status.

Is there any recent update on progress with getting upgrade status to detected deprecated hooks?

Failing that is there a way to get a full list of all hooks deprecated in 9.x and removed in 10?

Patched worked for me also, any chance of getting a new release tagged?

+1 @richgerdes anything else required to get a D10 tagged release?

@ayalon anything else required to get a D10 tagged release?

@manuel.adan any update on a D10 compatible release or does this just require a review?

Confirming also that the latest patch was used on multiple sites in production without issues, so I also agree that this patch is good to go.

Thank you

millnut → created an issue.