🇬🇧United Kingdom @millnut

Account created on 9 July 2020, almost 4 years ago
#

Recent comments

🇬🇧United Kingdom millnut

Yep so the WYWIWYG text format gets installed by the localgov_media module under "config/optional", which is a submodule of the localgov_core module.

I tested this under a minimal profile so no existing WYSIWYG text format, I'll generate a full config export later today

🇬🇧United Kingdom millnut

millnut changed the visibility of the branch 3408100-add-gitlab-ci to active.

🇬🇧United Kingdom millnut

millnut changed the visibility of the branch 3408100-add-gitlab-ci to hidden.

🇬🇧United Kingdom millnut

Yeah no problem I've just committed the code back into the main branch here which breaks the recipe apply with the error above https://github.com/millnut/localgov_recipe

🇬🇧United Kingdom millnut

This should be good to merge and fix the gitlab-ci errors

🇬🇧United Kingdom millnut

millnut changed the visibility of the branch 3413221-update-gitlab-ci-file to active.

🇬🇧United Kingdom millnut

millnut changed the visibility of the branch 3413221-update-gitlab-ci-file to hidden.

🇬🇧United Kingdom millnut

Works for me also, would be good to get a tagged release with this in

🇬🇧United Kingdom millnut

Just to update we are also seeing unexpected results when setting permissions in the UI, more context here https://github.com/localgovdrupal/localgov_microsites_group/issues/427#i....

@LOBsTerr do you have any ideas on this?

🇬🇧United Kingdom millnut

Ready for review; phpcs fails due to coding standards issues; and similar warning for eslint but that is currently set to warning only.

🇬🇧United Kingdom millnut

Changed to "Active" as I want to look into getting a matrix setup to test against both PHP 8.1 and 8.2 and hard fail coding standards so it matches the github workflow.

🇬🇧United Kingdom millnut

Ignore composer require failures, I didn't realise that is from DrupalCI manual runs. The GitLab CI pipeline passes with warnings on phpcs and eslint.

Those warnings I can pick up once the gitlabci file is merged in.

🇬🇧United Kingdom millnut

Confirming this patch 16 fixes my issue in Drupal 9.5.x, with the minimal test case below.

- Creating new content
- Required Date field in a paragraph with no default value set
- Using media library for an image field

Results in an AJAX error and the media library popup not opening

🇬🇧United Kingdom millnut

We've just hit this doing an upgrade from Drupal 9.5 to Drupal 10 where deprecated hooks are not flagged in upgrade status.

Is there any recent update on progress with getting upgrade status to detected deprecated hooks?

Failing that is there a way to get a full list of all hooks deprecated in 9.x and removed in 10?

🇬🇧United Kingdom millnut

+1 @richgerdes anything else required to get a D10 tagged release?

🇬🇧United Kingdom millnut

@ayalon anything else required to get a D10 tagged release?

🇬🇧United Kingdom millnut

@manuel.adan any update on a D10 compatible release or does this just require a review?

🇬🇧United Kingdom millnut

Confirming also that the latest patch was used on multiple sites in production without issues, so I also agree that this patch is good to go.

Production build 0.69.0 2024