- Merge request !3734Draft: Issue #3328429: Create item list field formatter for displaying ordered and unordered lists → (Open) created by trackleft2
- Assigned to arunkumark
- 🇮🇳India arunkumark Coimbatore
As per the suggestion introduced a new Field formatted to show the Text, Number, and Entity reference fields in the List Item format.
Created MR for the patch.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 8:54am 29 March 2023 - Merge request !3742Issue #3328429: Create item list field formatter for displaying ordered and unordered lists → (Open) created by arunkumark
- 🇮🇳India arunkumark Coimbatore
The Commands failed because there were minor issues with the EntityReferenceLabelListFormatter file. The uploaded patch meets the Drupal coding standards and best practices.
- Status changed to Needs work
over 1 year ago 5:19pm 31 March 2023 - 🇺🇸United States smustgrave
The failures appear to be legit.
This will need test coverage as well.
- First commit to issue fork.
- First commit to issue fork.
- last update
over 1 year ago 29,294 pass, 3 fail - last update
over 1 year ago 29,294 pass, 3 fail - 🇺🇸United States trackleft2 Tucson, AZ 🇺🇸
Thanks to all that contributed to this.
I've updated the remaining tasks with the tests that we should add for this.
See Example of functional test that checks a field formatter.
1. https://git.drupalcode.org/project/drupal/-/blob/10.1.x/core/modules/tax... for an example of testing a field formatter.See Example of Kernel test that checks a field formatter.
2. https://git.drupalcode.org/project/drupal/-/blob/10.1.x/core/modules/fie...We could probably get by with 3 tests (
ol
,ul
,csv
) in each of these files- https://git.drupalcode.org/project/drupal/-/blob/10.1.x/core/modules/fie...
- https://git.drupalcode.org/project/drupal/-/blob/10.1.x/core/modules/fie...
Plus a new test file for TextListItemTest.php that follows the same paradigm as the other two.
- last update
over 1 year ago 29,356 pass, 3 fail - 🇺🇸United States trackleft2 Tucson, AZ 🇺🇸
trackleft2 → changed the visibility of the branch 3328429-create-item-list to hidden.
- 🇺🇸United States trackleft2 Tucson, AZ 🇺🇸
trackleft2 → changed the visibility of the branch 11.x to hidden.
- 🇺🇸United States trackleft2 Tucson, AZ 🇺🇸
trackleft2 → changed the visibility of the branch 10.1.x to hidden.
- 🇺🇸United States trackleft2 Tucson, AZ 🇺🇸
trackleft2 → changed the visibility of the branch 3328429-create-item-list to active.