- @trackleft2 opened merge request.
- Assigned to arunkumark
- 🇮🇳India arunkumark Coimbatore
As per the suggestion introduced a new Field formatted to show the Text, Number, and Entity reference fields in the List Item format.
Created MR for the patch.
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 8:54am 29 March 2023 - @arunkumark opened merge request.
- 🇮🇳India arunkumark Coimbatore
The Commands failed because there were minor issues with the EntityReferenceLabelListFormatter file. The uploaded patch meets the Drupal coding standards and best practices.
- Status changed to Needs work
about 1 year ago 5:19pm 31 March 2023 - 🇺🇸United States smustgrave
The failures appear to be legit.
This will need test coverage as well.
- First commit to issue fork.
- First commit to issue fork.
- last update
about 1 year ago 29,294 pass, 3 fail - last update
about 1 year ago 29,294 pass, 3 fail - 🇺🇸United States trackleft2
Thanks to all that contributed to this.
I've updated the remaining tasks with the tests that we should add for this.
See Example of functional test that checks a field formatter.
1. https://git.drupalcode.org/project/drupal/-/blob/10.1.x/core/modules/tax... for an example of testing a field formatter.See Example of Kernel test that checks a field formatter.
2. https://git.drupalcode.org/project/drupal/-/blob/10.1.x/core/modules/fie...We could probably get by with 3 tests (
ol
,ul
,csv
) in each of these files- https://git.drupalcode.org/project/drupal/-/blob/10.1.x/core/modules/fie...
- https://git.drupalcode.org/project/drupal/-/blob/10.1.x/core/modules/fie...
Plus a new test file for TextListItemTest.php that follows the same paradigm as the other two.
- last update
about 1 year ago 29,356 pass, 3 fail