- 🇺🇸United States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
Removing the tests tag as they appear to have been added.
Tagging for framework review to see if this is something they want to allow.
Also usability to see if there will be an issue.But this needs an issue summary update. Recommend following the default template.
- 🇺🇸United States dww
From the looks of the latest patch, #9 is still not addressed. The point isn't to try to implement this without trying to use the
Settings
class. The point is that callingSettings::get()
might throw and exception and explode, and we need to be okay with that. Hence the need fortry
in here, and fall-back to the hard-coded thing if that function dies. 8:28 5:30 Running- last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago 30,279 pass, 1 fail - last update
over 1 year ago 30,342 pass - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Custom Commands Failed - 🇮🇳India atul4drupal
Updated patch to fix the error.
Addressed #61 ✨ Ability to Customize Core Error Message Needs workKindly review and suggest.
Thanks. - last update
over 1 year ago 30,380 pass - Status changed to Needs review
over 1 year ago 8:47am 5 October 2023 - Status changed to Needs work
over 1 year ago 1:59pm 5 October 2023 - 🇺🇸United States smustgrave
IS is still incomplete and should follow the standard template for issue. It's adding a value to the settings.php and screenshots should be included.
Also feel the tests should be updated to test that the string is updated
$this->assertStringContainsString($settings->get('custom_error_message'), $response->getContent());
With the catch added and if it's falling back to the default message this would still pass right?