Patch in #7 is working for me
(aligning with changes in page_manger since patch from Path has unnecessary query appended is committed)
Drupal in #43 was also working for Drupal 10.3.1,
but Drupal 10.3.2 brings some clean up of comments in views module. Patch in #43 includes some of these that are therefore not needed anymore => removed from this patch
I had to complete the signature, adding :array, indeed.
Patch attached
There is actually at least one other cause for such a Warning.
Because of
foreach ($counters as $key => $counter) {
if ($counter['amount'] === 0) {
continue;
}
in getCounter() function
$counter['warning']['amount'] (line 118)
$counter['error']['amount'] (line 121)
may not be set in buildRenderArray() function if there are no warning/error.
Attached patch goes for "isset" check, alternative would be to remove the foreach and keep all three counters
Looks like the problem might be around the final logger (logger.drupaltodrush).
For me, trace was:
Got error 'PHP message: Uncaught PHP Exception Symfony\\Component\\DependencyInjection\\Exception\\ServiceCircularReferenceException: "Circular reference detected for service "Drupal\\Core\\Logger\\LoggerChannelFactoryInterface", path: "options_request_listener -> router.route_provider -> path_processor_manager -> simple_sitemap.engines.path_processor -> simple_sitemap.engines.index_now_submitter -> simple_sitemap.logger -> logger.channel.simple_sitemap -> Drupal\\Core\\Logger\\LoggerChannelFactoryInterface -> logger.syslog -> workspaces.manager -> logger.channel.workspaces"."
https://www.drupal.org/project/drupal/issues/3103620 🐛 Dependency on config storage causes circular reference in service container Needs review solved it for me
Looks like patch suggested in #3 did if for me too
Sorry, got a bit too enthousiast.
Here is a new try, limiting "return" in patch #5 to empty string
Patch #5 breaks Data Comparison if value = 0 so let's check if value is a string before going for return