- π¦πΊAustralia mstrelan
I don't think we should be using
@return foo|void. If we want to add a native return type later this is invalid, it has to either return something or not.For
_batch_next_setit's called by_batch_processwhich treats the return as a bool, so for that one I think we could just return FALSE.For
batch_processthe places that call it seem to check if the return value is aResponseor not, so we should return NULL otherwise. Similar for_batch_queue, not sure why we wouldn't return NULL here.install_run_taskshould quite obviously return NULL and not void. It's called like this:$output = install_run_task($task, $install_state);. If we return void it just gets coerced to NULL anyway. Same forinstall_get_formwhich is called frominstall_run_taskI'm happy to work on this if people agree with this point of view.