- 🇮🇹Italy mondrake 🇮🇹
Unpublished CR - this was not done when the commit was reverted.
- Open on Drupal.org →Environment: PHP 8.2 & MySQL 8last update
over 1 year ago Not currently mergeable. - @mondrake opened merge request.
- last update
over 1 year ago Custom Commands Failed - @mondrake opened merge request.
- last update
over 1 year ago 29,825 pass, 2 fail - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 29,634 pass, 63 fail - last update
over 1 year ago 29,876 pass, 2 fail - last update
over 1 year ago Unable to generate test groups - last update
over 1 year ago Unable to generate test groups - last update
over 1 year ago 29,863 pass, 1 fail - last update
over 1 year ago 29,804 pass, 5 fail - @mondrake opened merge request.
- last update
over 1 year ago 29,862 pass, 1 fail - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 29,878 pass - Status changed to Needs review
over 1 year ago 4:36pm 23 July 2023 - 🇮🇹Italy mondrake 🇮🇹
MR 4452 is another attempt at this. Starting from the previous approach, this uses service aliasing to allow keeping calling the extension by class name, and finally deprecates
Connection::getDriverClass()
. - Status changed to Needs work
over 1 year ago 9:24pm 25 July 2023 - last update
over 1 year ago 29,879 pass - Status changed to Needs review
over 1 year ago 4:45pm 26 July 2023 - 🇮🇹Italy mondrake 🇮🇹
I think I addressed all of @daffie's points. Thanks.
- Status changed to Needs work
over 1 year ago 8:29am 31 July 2023 - 🇳🇱Netherlands daffie
The last couple of nitpicks.
After this it is RTBC for me. - last update
over 1 year ago 29,816 pass, 2 fail - last update
over 1 year ago 29,912 pass - Status changed to Needs review
over 1 year ago 7:42pm 31 July 2023 - last update
over 1 year ago 29,912 pass - last update
over 1 year ago 29,912 pass - Status changed to RTBC
over 1 year ago 1:32pm 1 August 2023 - 🇳🇱Netherlands daffie
All code changes look good to me.
All my points have been addressed.
The IS and the CR are in order.
For me it is RTBC. - last update
over 1 year ago 29,947 pass - last update
over 1 year ago 29,953 pass, 1 fail - last update
over 1 year ago 29,954 pass - last update
over 1 year ago 29,959 pass - last update
over 1 year ago 29,959 pass - last update
over 1 year ago 29,959 pass - last update
about 1 year ago 29,960 pass - last update
about 1 year ago 29,972 pass - last update
about 1 year ago 30,050 pass - last update
about 1 year ago 30,057 pass - last update
about 1 year ago 30,053 pass, 2 fail - 🇳🇿New Zealand quietone
I'm triaging RTBC issues → . I workd on this a few days ago as well.
I corrected a typo in the release snippet I saw when reading the Issue Summary.
I read the comments the other day and refreshed my memory just now. I did not find any unanswered queries there. The only thing is the followup to create at some point.
I am leaving this at RTBC.
- last update
about 1 year ago Custom Commands Failed - Status changed to Needs work
about 1 year ago 5:07pm 26 August 2023 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- last update
about 1 year ago 30,061 pass - last update
about 1 year ago 30,061 pass - last update
about 1 year ago 30,061 pass - Status changed to RTBC
about 1 year ago 8:57am 28 August 2023 - 🇮🇹Italy mondrake 🇮🇹
Rebased and added
@phpstan-ignore-next-line
to calls of deprecated methods that are left in for BC purposes. Back to RTBC. - last update
about 1 year ago 30,099 pass - last update
about 1 year ago 30,130 pass, 2 fail - last update
about 1 year ago 30,119 pass, 2 fail - last update
about 1 year ago 30,131 pass - 🇮🇹Italy mondrake 🇮🇹
Rebased after commit of the transaction refactor issue.
- last update
about 1 year ago 30,136 pass - last update
about 1 year ago 30,135 pass, 2 fail - last update
about 1 year ago 30,137 pass - last update
about 1 year ago 30,147 pass - last update
about 1 year ago 30,147 pass - 🇳🇿New Zealand quietone
Updated the branch/version on the CR. I did not review the CR.
28:51 27:36 Running- last update
about 1 year ago 30,147 pass, 1 fail - last update
about 1 year ago 30,160 pass, 2 fail - last update
about 1 year ago 30,169 pass - last update
about 1 year ago 30,169 pass - last update
about 1 year ago 30,206 pass - last update
about 1 year ago 30,207 pass - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - Open on Drupal.org →Environment: PHP 8.2 & pgsql-14.1
58:52 58:52 Queueing - last update
about 1 year ago Custom Commands Failed - Open on Drupal.org →Environment: PHP 8.2 & pgsql-14.1last update
about 1 year ago Not currently mergeable. - Open on Drupal.org →Environment: PHP 8.2 & pgsql-14.1last update
about 1 year ago Not currently mergeable. - Open on Drupal.org →Environment: PHP 8.2 & pgsql-14.1last update
about 1 year ago Not currently mergeable. - Open on Drupal.org →Environment: PHP 8.2 & pgsql-14.1last update
about 1 year ago Not currently mergeable. - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago 30,428 pass - last update
about 1 year ago 30,438 pass - last update
about 1 year ago 30,442 pass, 1 fail - last update
about 1 year ago 30,465 pass - last update
about 1 year ago 30,484 pass - last update
about 1 year ago 30,486 pass 13:52 10:00 Running- last update
about 1 year ago 30,489 pass 28:53 23:26 Running28:51 24:05 Running- Status changed to Needs work
about 1 year ago 10:32pm 12 November 2023 - 🇺🇸United States xjm
The followup is still needed. It's a followup, not a blocker, so we can still go ahead here. We've also made coding standards progress on allowing the protected property promotion and the multi-line constructor format.
We do still need that additional framework manager feedback.
Meanwhile, there are various quite small coding standards issues with the MR, plus any number of inline comments we don't actually need. Plus, the scope of the D11 removal of the BC layer is sufficiently beyond a simple deprecation that we should go ahead and file the D11 followup now. (An existing issue was closed as outdated -- either it should be reopened and rescoped to be a part of the D11 beta requirements, or it should be replaced by an issue that is.)