Provide the ability to wrap the entire page with a border when opening off-canvas in the top position

Created on 30 May 2018, over 6 years ago
Updated 9 January 2024, 11 months ago

Problem/Motivation

The Workspace UI prototype (https://marvelapp.com/2db8i71/screen/26360612) brought up the need to have the off-canvas dialog at the top of the page, a change which was implemented in #2916781: Allow off-canvas dialog to be rendered at the top of the page .

However, there is another aspect of the top off-canvas design proposal which was not considered in that issue: opening a top off-canvas dialog should convey the fact that you are editing something which impacts your whole site, as opposed to the side off-canvas dialog where you edit something related to current page only.

The design choses to make the "site-wide impact" more prominent by wrapping the entire site with a 40px dark gray border.

Proposed resolution

Should we implement this aspect of the design generically in the off-canvas library? The reason would be that any other module which uses the top off-canvas dialog position need to convey a similar message, that you are editing something with a site-wide impact.

Another option is to make this "wrapping" behavior opt-in, allowing developers to specify whether it should be added or not.

Remaining tasks

Discuss, work on a patch.

User interface changes

The top off-canvas dialog also wrap the site content with a border.

API changes

Nope.

Data model changes

Nope.

Feature request
Status

Active

Version

11.0 🔥

Component
Javascript 

Last updated 2 days ago

Created by

🇷🇴Romania amateescu

Live updates comments and jobs are added and updated live.
  • Needs usability review

    Used to alert the usability topic maintainer(s) that an issue significantly affects (or has the potential to affect) the usability of Drupal, and their signoff is needed. When adding this tag, make it easy to review the issue. Make sure the issue summary describes the problem and the proposed solution. Screenshots usually help a lot! To get sign-off on issues with the "Needs usability review" tag, post about them in the #ux channel on Drupal Slack, and/or attend a UX meeting to demo the patch and get direct feedback from designers/UX folks/product management on next steps. If an issue represents a significant new feature, UI change, or change to the general "user experience" of Drupal, use Needs product manager review instead. See the scope of responsibilities for product managers.

  • Accessibility

    It affects the ability of people with disabilities or special needs (such as blindness or color-blindness) to use Drupal.

  • Needs framework manager review

    It is used to alert the framework manager core committer(s) that an issue significantly impacts (or has the potential to impact) multiple subsystems or represents a significant change or addition in architecture or public APIs, and their signoff is needed (see the governance policy draft for more information). If an issue significantly impacts only one subsystem, use Needs subsystem maintainer review instead, and make sure the issue component is set to the correct subsystem.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024