- Issue created by @wim leers
- Merge request !984Issue #3522734: Rename `SdcPropToFieldTypePropMatcher` to... ā (Merged) created by Unnamed author
- š®š³India meghasharma
I have verified the changes related to renaming SdcPropToFieldTypePropMatcher to JsonSchemaFieldInstanceMatcher and SdcPropJsonSchemaType to JsonSchemaType.
1) Old class names (SdcPropToFieldTypePropMatcher, SdcPropJsonSchemaType) have been completely removed from the codebase.
2) New class names (JsonSchemaFieldInstanceMatcher, JsonSchemaType) are being used consistently throughout the module.
Everything looks good - š®š³India sandip
Thanks @larowlan for the feedback.. I am working on rename rest of the SdcProp usage.
- š¦šŗAustralia larowlan š¦šŗš.au GMT+10
wim leers ā credited larowlan ā .
- š®š³India sandip
I have rename all the SdcProp usage but still some tests seems failed. I am not getting why it is so. @wim leers and @ larowlan can you please take a look into it.
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Thanks so much, @sandip, this feels way better! š
-
wim leers ā
committed 64ac169f on 0.x authored by
sandip ā
Issue #3522734 by sandip, wim leers, meghasharma, larowlan: Rename `...
-
wim leers ā
committed 64ac169f on 0.x authored by
sandip ā
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
@sandip If you're interested in doing more of this valuable work: š Rename `FieldForComponentSuggester` to `StructuredDataSourceSuggester` Active šš¤
- š®š³India sandip
@wim leers, Thanks for the issue:) I noticed someone has already taken care of this issue before me. Appreciate the opportunity. I'll keep an eye out for more tasks like this š
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
@sandip There's a round of feedback on that MR, and there's also š Create loadAutoSave() helper function Active š