Clarify default 'resolved' vs 'source' value logic in GeneratedFieldExplicitInputUxComponentSourceBase::getClientSideInfo()

Created on 19 February 2025, about 2 months ago

Overview

\Drupal\experience_builder\Plugin\ExperienceBuilder\ComponentSource\GeneratedFieldExplicitInputUxComponentSourceBase::getClientSideInfo() has grown rather unwieldy recently, between:

  1. 📌 Maintain a per-component set of prop expressions/sources Active
  2. 🐛 Adding the Image component results in a state considered invalid Active

having both recently landed.

I worry that it's become impossible to understand. Plus, there's a few leftover @todos that AFAICT are obsolete. For sure this one:

     // @todo Add support for default images in SDCs: /components/image/image.component.yml. (And entity references in general.)

(That's literally what #3501902 fixed.)

Proposed resolution

Clarify it based on recent changes. This should also help pave the path for 📌 Split model values into resolved and raw Active .

User interface changes

None.

📌 Task
Status

Active

Version

0.0

Component

Data model

Created by

🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024