- Issue created by @wim leers
- Merge request !671Resolve #3507749 "Clarify default resolved vs source logic" → (Merged) created by wim leers
- First commit to issue fork.
- 🇬🇧United Kingdom longwave UK
I've gone a bit further with the refactoring of
::getClientSideInfo()
, several times we initialize one-time variables far away from where we use them so I moved them all closer to their usages, and also reordered some other things that make more sense to me. It's probably best to review individual commits and then the final result as a whole for it to make the most sense. - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
@longwave took what I did and performed a master class in how to refactor further, step-by-step. The end result is much more readable than what I proposed.
Wonderful, thanks! 🤩👏
Landing this because it's being built on by 📌 ComponentMetadataRequirementsChecker::check() should validate that the example(s) actually match the JSON schema Active , which is in the sprint. At this point, @longwave and I made equal amounts of changes, and clearly this refactoring is helpful in addressing actual bugs, otherwise he wouldn't have started fixing #3507641 on top of this!
-
wim leers →
committed 4f793654 on 0.x
Issue #3507749 by longwave, wim leers: Clarify default 'resolved' vs '...
-
wim leers →
committed 4f793654 on 0.x
Automatically closed - issue fixed for 2 weeks with no activity.