Deprecate and remove `status` and `info` settings from `block_content` blocks

Even though we could easily land this before 📌 Make Block config entities fully validatable Fixed , I think it's better not to.

Because #3379725 will bring much needed-clarity: that status and info belong in type: block.settings.block_content:*, instead of in type: block_settings (that's where they currently reside).

Because #3379725 will bring much needed-clarity: that status and info belong in type: block.settings.block_content:*, instead of in type: block_settings (that's where they currently reside).

The changes in #3379725 will also cause most (I actually think all) test failures on the current MR to disappear. That's another important reason to postpone this issue: if we wait for that to land, then this issue's MR can stay as simple as it is today!

Parent issue landed, so we can fix this now.

Fixed merge conflicts and created a CR, still NW as we need an upgrade path

https://www.drupal.org/node/3499836 →

It looks like a lot of the test failures are now something like this:

    1) /builds/issue/drupal-3426302/core/lib/Drupal/Core/Config/Schema/SchemaCheckTrait.php:211
    The 'status' setting for content blocks is deprecated in drupal:11.2.0 and is removed from drupal 12.0.0. It was unused, so there is no replacement. See https://www.drupal.org/node/3499836.

Which is coming from an update path test, I'm assuming because the db fixture has those keys set. Not entirely sure how we usually solve this kind of thing.

The fix for #8 was glaring me in the face, we needed an update path to fix those deprecations.

I'll work on an update path test next.

This is good to go now

If we remove the status field won’t that preventing unpublishing of a block now

That's a top level setting on the block itself. These settings that we are removing do absolutely nothing.

Left 1 comment on MR

If you are another contributor eager to jump in, please allow the previous poster at least 48 hours to respond to feedback first, so they have the opportunity to finish what they started!

My mistake.

rest of the change appears good to me then

Left some MR feedback about the upgrade path.