Move `PropSourceEndpointTest` into new `XbConfigEntityHttpApiTest::testComponent()`

Created on 4 March 2025, 2 months ago

Overview

@tedbow was forced to introduce PropSourceEndpointTest in 📌 HTTP API: update /xb-component/{component_id} to list possible prop sources for current entity context Fixed , because no functional tests existed for that internal HTTP API response yet.

That was merged August 29, 2024.

ApiConfigControllers and its corresponding functional test coverage at XbConfigEntityHttpApiTest were both introduced in 📌 HTTP API to read+write PageTemplate and Pattern config entities Active by yours truly on October 22, 2024, in an attempt to curb the explosion in number of (routing) controllers.
Months later, that attempt has proven succesful 👍

However, the one outlier now is PropSourceEndpointTest.

Proposed resolution

The PropSourceEndpointTest test coverage ought to be moved into XbConfigEntityHttpApiTest, and match the existing naming scheme, so it should be in a test method named ::testComponent().

User interface changes

None.

📌 Task
Status

Active

Version

0.0

Component

Internal HTTP API

Created by

🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @wim leers
  • First commit to issue fork.
  • Merge request !770Issue #3510896: Move test → (Open) created by acbramley
  • 🇦🇺Australia acbramley

    I would say this isn't so Novice, the tests are quite complicated. I had to:

    1. Swap to standard profile
    2. Modify cache tags in existing tests to match
    3. Enable some new modules
    4. Port over helper functions

    Locally these tests are throwing a bunch of warnings but I'm testing out the ddev XB setup so it might be related to that.

  • 🇦🇺Australia acbramley

    Not too sure what's causing those unrelated test failures!

  • Pipeline finished with Failed
    about 2 months ago
    Total: 4653s
    #445254
  • 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
  • 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

    Not too sure what's causing those unrelated test failures!

    Hm … me neither, but this seems like yet another case of https://www.drupal.org/project/gitlab_templates being wrong and running contrib module's test suites differently for non-maintainer-pushed commits than for maintainer-pushed commits 😬 (I wish I was kidding!)

    Also: you're right, I misjudged, this is not a trivial move. 🙈 Thanks for removing the tag.

    But … this issue is novice-like in the sense that you were able to do this without deep XB knowledge! 😄 What do you think would be a more appropriate tag? 😊

Production build 0.71.5 2024