- Issue created by @wim leers
- Merge request !366#3479982: HTTP API to read+write PageTemplate and Pattern config entities → (Merged) created by wim leers
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
The MR should now be green and supports the following operations for
PageTemplate
config entities, with detailed test coverage:- listing all
- reading individual ones
- deleting individual ones — with a
@todo
for still needing to validate no other config entities depend on this one, see ✨ [PP-4] JSON:API DELETE support for config entities Active .
Next up:
POST
andPATCH
support, which is what will involve copying parts of ✨ [PP-2] POST/PATCH config entities via REST for config entity types that support validation Needs work . - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Per #4 and the green CI pipeline: ready for an initial review pass :)
(Tip: look at the diff locally, and exclude the first commit — which is literally just bringing in 📌 Introduce an XB `PageTemplate` config entity Active .)
- 🇬🇧United Kingdom longwave UK
As usual the approach looks good so far but the proof will be in the PATCH and POST APIs!
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
📌 Introduce an XB `PageTemplate` config entity Active landed. Merged upstream
0.x
into this MR; this MR is now much smaller 👍 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Fully ready, including detailed functional tests that prove config validation is doing its job 😊
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
BTW: one part I know still needs to happen: document the response shapes in
/openapi.yml
. But given my upcoming reduced availability, I think it'd be better for somebody else to take that on 😇 - First commit to issue fork.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Reviewed by both @tedbow (from HTTP API POV) and @f.mazeikis (from config management POV), and previously by @longwave (from core committer POV).
All feedback addressed.
Let's land this :)
-
wim leers →
committed adadbecd on 0.x
Issue #3479982 by wim leers, tedbow, longwave: HTTP API to read+write...
-
wim leers →
committed adadbecd on 0.x
Automatically closed - issue fixed for 2 weeks with no activity.