- Issue created by @wim leers
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
Discussed with @longwave, we agreed that this would make sense for him to tackle after ๐ Introduce an XB `PageTemplate` config entity Active lands, because it adds the validation constraint that will make this trivial to implement.
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
๐ Introduce an XB `PageTemplate` config entity Active is in.
๐ HTTP API to read+write PageTemplate and Pattern config entities Active is also already green, and is written in a sufficiently generic way that this should also just work!
This is actionable now. There's plenty of examples/blueprints to follow from #3478537.
Unassigning @longwave, who is on vacation right now :)
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
๐ HTTP API to read+write PageTemplate and Pattern config entities Active is in!
This should also expand the test coverage that #3479982 introduced for: this MR should add a
testPattern()
method as a sibling toXbConfigEntityHttpApiTest::testPageTemplate()
. - ๐บ๐ธUnited States be-a-helper
I know this isn't MVP, but will it be possible to validate above the component tree level?
I've repeatedly seen content management tools fail to recognize that both content and context validation are real needs, and if you're validating the meta relationships between components it makes sense to be able to query the component models as well.
Some example criteria a marketing approver might use:
1. A page can display more than one location component, but not if they have the same entity reference.
2. A page may have a carousel or a left column, but not both
3. A page must reference the title at least 4 times for SEO
4. All metadata keywords must be present in page content - ๐ซ๐ฎFinland lauriii Finland
@be-a-helper This seems outside the scope of this issue. Could you file a new issue for that question?
Few interesting edge cases that came up in the design process:
- User should be able to undo adding or โdeletingโ a section from the library (I.e. CMD+Z)
- User should be able to undo inserting a section (I.e. CMD+Z)
I'm wondering if this has implications on the data model?
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
#10:
will it be possible to validate above the component tree level?
Yes. See ๐ Tighten validation: only allow StaticPropSource in XB fields + PageTemplate, DynamicPropSource in ContentTypeTemplate Active for an example of the precision of validation that is already present :)
It'd be trivial to add more validation constraints โ either for the XB module itself or for contrib/custom modules.
The 4 examples you cite would all be possible to implement. But the real challenge will be in which level to apply such validation constraints to: individual content entities (so at the XB field type level:
\Drupal\experience_builder\Plugin\Field\FieldType\ComponentTreeItem
) or at the content entity type bundle level (not yet implemented, stretch goal for0.2.0
โ see ๐ฑ Milestone 0.2.0: Experience Builder-rendered nodes Active , requirement 9, which is a stretch goal.Agreed with @lauriii in #11 that #10 is out of scope for this issue. A new issue for your described use cases would be very much appreciated, but should be postponed on ๐ฑ [later phase] [META] 7. Content type templates โ aka "default layouts" โ affects the tree+props data model Active .
- ๐ฌ๐งUnited Kingdom f.mazeikis Brighton
f.mazeikis โ made their first commit to this issueโs fork.
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
Nice to see this getting started, @f.mazeikis โ did a very high-level initial review pass ๐ค
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
๐ Reviewed again.
This time in slightly more detail.
Now that ๐ Add support for Blocks as Components Active is in, we can properly push this forward ๐
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
FYI, the validation pieces I mentioned above are blocked on ๐ `ComponentTreeMeetRequirements` constraint validator must be updated now that Blocks-as-Components are supported Active . ๐
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
๐ `ComponentTreeMeetRequirements` constraint validator must be updated now that Blocks-as-Components are supported Active is in! This is now properly unblocked ๐
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
Down to 2 non-commit blocking nits that would be nice to see resolved prior to merging, but I've already approved the MR โ thanks @f.mazeikis! ๐
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
Wow, in order to achieve the thoroughness of test coverage, to gain the necessary confidence that XB's config entities do indeed meet the
14. Configuration Management
product requirement, I had to add a bit of infrastructure that Drupal core seems to be wholly missing ๐คฏ https://git.drupalcode.org/project/experience_builder/-/merge_requests/3...This was pointed out 8.5 years ago and still has not been resolved: ๐ Improve ConfigDependencyManager::getDependentEntities() documentation Needs work .
-
wim leers โ
committed 5e4aa297 on 0.x authored by
f.mazeikis โ
Issue #3479643 by f.mazeikis, wim leers: Introduce a `Pattern` config...
-
wim leers โ
committed 5e4aa297 on 0.x authored by
f.mazeikis โ
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
See you in โจ [PP-1] Integrate saving sections with the backend Postponed next, where the client will be updated to actually use this! ๐
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
We forgot to update
docs/config-management.md
in the already merged MR ๐Docs MR ready to be reviewed by @f.mazeikis.
-
wim leers โ
committed 8ba6d195 on 0.x
Issue #3479643 by f.mazeikis, wim leers: Introduce a `Pattern` config...
-
wim leers โ
committed 8ba6d195 on 0.x
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
Feel free to merge yourself next time! ๐
Automatically closed - issue fixed for 2 weeks with no activity.