- Issue created by @wim leers
- Status changed to Postponed
10 months ago 4:27pm 19 June 2024 - š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
This builds on top of š± Milestone 0.1.0: Experience Builder Demo Active , so marking this . That doesn't mean we're not working on this already: work is already happening and being coordinated in š± [META] Early phase back-end work coordination Active ā with some of the issues in there being necessary for š± Milestone 0.1.0: Experience Builder Demo Active .
(If there wasn't a hard DrupalCon Barcelona deadline, š± Milestone 0.1.0: Experience Builder Demo Active and this milestone/issue would probably be one and the same.)
- Assigned to lauriii
- Status changed to Active
7 months ago 11:12am 18 September 2024 - š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
š± Milestone 0.1.0: Experience Builder Demo Active is nearly done. DrupalCon Barcelona 2024 is in a few days.
Time to get this fleshed out!
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Also: do we want to keep using š± [META] Early phase front-end work coordination Active + š± [META] Early phase back-end work coordination Active ?
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Some markup changes to improve clarity/scannability.
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Initial issue for product requirement
19. Modify the page template
created: š Introduce an XB `PageTemplate` config entity Active . - šŗšøUnited States Kristen Pol Santa Cruz, CA, USA
Let me know if you want/need anything in SDDS for this next milestone as well as for DrupalCon Singapore.
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Overhaul of the meta to reflect which of the 10 requirements are actionable, and to what extent. 9 of the 10 cannot begin UI+UX (aka client side) work due to designs not being ready.
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Updated the status for and .
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
š HTTP API to read+write PageTemplate and Pattern config entities Active landed!
For
2.1. Content editing of meta fields
, a new issue was identified as blocking the0.2
milestone: š [later phase] [RESEARCH] How to identify all meta fields for an arbitrary content entity? Active . - š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Finished adding š¢, š” or š“ to every ā®.
Also clarified why the two stretch goals are pretty firmly out of reach already at this stage.
- šŗšøUnited States effulgentsia
Removed the stretch goals from the list. We're not currently working on them so there's no realistic plan of them getting done by early January.
- šŗšøUnited States effulgentsia
Also descoped (with confirmation from @lauriii) revisions and Workspaces from 0.2.0.
- šŗšøUnited States effulgentsia
The Purpose and Expected result sections are incomplete. They don't capture the entirety of the remaining items that are in the Requirements section. When I find a bit of time, I'll fill in those sections so that they add clarity as to what the overarching goal of the 0.2.0 milestone is.
- šŗšøUnited States effulgentsia
Updated the proof-of-concept issue for the component code editor from š [exploratory] StackBlitz PoC Active to āØ [exploratory] PoC of Preact+Tailwind components editable via CodeMirror or Monaco Active .
- šŗšøUnited States effulgentsia
I updated the "Content editing of meta fields" section with 0.2.0 scope vs 0.3.0 scope.
- šŗšøUnited States effulgentsia
I'm retitling this issue from 0.2.0 to 0.3.0, and changing its target date from mid January to late February.
In the meantime, we'll release a 0.2.0 on or before Jan. 13, so that the Drupal CMS 1.0 release on Jan. 15 can reference a tagged release of XB. I'll open a separate issue for that; it won't include all of the scope of this one.
- šŗšøUnited States effulgentsia
Here's the one for 0.2.0: š± Milestone 0.2.0: the one for Drupal CMS 1.0 Active
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Updated the
19. Modify the page template
(i.e. global sections) requirement. It's working, but there's 3 currently known rough edges:- Assigned to: jessebaker š Empty global regions add unnecessary spacing to preview Active
- š If an autosave entry exists before enabling global regions for a theme, theme regions cannot be seen Active
- Assigned to: balintbrews āØ Focus mode for global regions Active , blocked on Assigned to: parthbcharya āØ Show page information in top bar Active
- šŗšøUnited States tedbow Ithaca, NY, USA
re "Save (draft) content:"
we already have
and a Publish button to trigger a real entity save:
but I guessing what we want for 0.3.0 is the "Publish all" and we will remove the individual entity save button.
@effulgentsia if that is correct I will add the issues that get use to "Publish all" to the summary
- šŗšøUnited States effulgentsia
what we want for 0.3.0 is the "Publish all" and we will remove the individual entity save button
Correct. I updated the corresponding text in the IS, but yeah, if you could update the corresponding issue list, that would help a lot, thanks!
- šŗšøUnited States effulgentsia
I updated the IS to change other occurrences of 0.2.0 in the summary to 0.3.0.
- šŗšøUnited States effulgentsia
With drupal.org's CSS, I'm finding the nested list hard to read. So I updated the IS to use
<h3>
headings for each high level capability instead. - š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
@effulgentsia Did you intentionally delete
?
- šŗšøUnited States effulgentsia
I did, because I thought it wasn't time yet to be tracking general "fix broken stuff" issues here yet. But I just now restored it under a new "Miscellaneous high priority fixes" heading.
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Updated the
29. Layout patterns
(i.e. sections) requirement.(And also updated
19. Modify the page template
's issue list ā lots of activity over there this week.) - š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
One more for
19. Modify the page template
, that was created a few hours ago! - š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Add anchors to facilitate deeplinking.
- šŗšøUnited States effulgentsia
Not wanting to take the time right now to figure out how to best organize these within the issue summary, but the following issues are still needed as part of "Place Blocks as Components":
- š [Needs design] Library confusingly lists SDC-sourced and Block-sourced Components together Active
- š Implement saving block settings forms Active
I wonder if we should turn each of the top-level requirements, such as "Place Blocks as Components", into their own Plan issue, so that we can make those the parent of individual issues like the above.
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
I wonder if we should turn each of the top-level requirements, such as "Place Blocks as Components", into their own Plan issue, so that we can make those the parent of the above issues and similar individual issues for the other top-level requirements.
-1 ā too much overhead and issue queue noise. I'd rather have a single issue with >200 updates than having to monitor half a dozen issues, each of which causes actual MR issues to be somewhat obscured.
Updated 5. Place blocks as components ā included everything @effulgentsia listed in #44 and expanded.
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
āØ [PP-1] Integrate saving sections with the backend Postponed just landed, which means
29. Layout patterns
is AFAICT the first requirement to be completely done! š„³ - šŗšøUnited States tedbow Ithaca, NY, USA
Added issue for the "Save (draft) content" section. I am still looking for more issues to add
- šŗšøUnited States effulgentsia
In addition to š [PP-1] Send page data to Drupal for storage in auto-save store Postponed: needs info being under the "Save (draft) content" requirement, it's also the last remaining item for "Content editing of meta fields", so landing it would give us another nice green checkmark in front of a top-level requirement.
š± [META] Pages Active is still listed in the IS under "Content editing of meta fields" but the remaining children of that are being tracked separately under that meta and don't need to block this issue.
- šŗšøUnited States tedbow Ithaca, NY, USA
Finished going through issue queue for 6. Save (draft) content section
I think we are close but we mind unknown issues once āØ [PP-1] Implement the "Publish All" button Postponed is completed as they will allow use to do the whole process. For this to include entity fields we will need the 2.1. Content editing of meta fields section to be done too
As far as know is š Some components cannot be used in XB because UI prevents SDC props being named `name` Active isn't required for 0.3.0
- šŗšøUnited States effulgentsia
As far as know is š Some components cannot be used in XB because UI prevents SDC props being named `name` Active isn't required for 0.3.0
Yeah, that issue and its children should be moved in the IS from the "save content" requirement to the "blocks" requirement. It's possible that the entirety of that isn't required for 0.3.0, but the parts that are blocking š Implement saving block settings forms Active are.
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Thanks, @tedbow! Updated that
6. Save (draft) section
section to follow the same structure as the others (BE/FE/E2E/Polish). Some were miscategorized. Some icons were off. But I kept the same set of issues.Thanks, that really helped!
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
And now adding + removing issues to that same section.
Added:
- š Save metadata(page data) field with the entity revision Active
- š Create an endpoint to publish all auto-saved entities Active
- š Create AutoSave service and HTTP API to retrieve all entities with pending changes Active
- āØ Save page data form values in application state with support for undo/redo Active
Removed (given my understanding of Lauri's original product requirements, but I was not in every meeting while working at limited capacity during paternity leave, so correct me if I'm wrong š):
- š [later phase] Support matching `{type: array, ā¦}` prop shapes Postponed ā we should absolutely do this and it is a stable blocker, but this was never intended to be solved as part of this
- š Add typed value-objects for the component tree structure Needs review ā definitely never intended to be solved as part of this
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Moved š [PP-2] Don't store page template model data in auto-save for an entity Postponed to for "Save (draft) content", and added a placeholder for the missing validation error support.
Also marked both "Save (draft) content" and "Modify the page template (i.e. global regions)" as š¢ ā but not yet ā : I have high confidence we'll be able to wrap those up given the current status + pace + outlook, but they're not yet done.
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Fixed formatting and added jumplinks.
- šŗšøUnited States tedbow Ithaca, NY, USA
@Wim Leers re #54 ok. yeah I reread the issue in š [PP-2] Don't store page template model data in auto-save for an entity Postponed . I missed this part
The values are filtered out in \Drupal\experience_builder\Controller\ClientServerConversionTrait::clientModelToServerProps but we are storing more in the autosave/tempstore than we need to.
I thought there would be conflict in "Publish All" phase because each entity could have its own copy of the global regions that could conflict. Now I see it is just extra data we don't actually use. So +1 on moving it to "Polish" section
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Introducing an explicit to allow identifying which things are known to be needed in the future, but explicitly omitted from the
0.3
scope. - š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Discussing this with @effulgentsia and @lauriii. To enable @lauriii to specify which polish he considers necessary for meeting the product requirements, I need to:
- clearly distinguish between must-have (all the "foundations" bits), should-have (the "polish for long-term API stability" aka avoid technical debt) and nice-to-have ("polish for later phase")
- I should first order the should-have lists by what I perceive to be priority order; this enables @lauriii to either confirm or ask for changes
This update to the issue summary only does the first bit.
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
#59.2 ā pass 3 of 3.
Still outstanding:
- Reconciling the should-haves for
6. Save (draft) content
with those of5. Place blocks as components
ā both are impacted by/need changes to the data model. I still need to dig deeper to be able to articulate which falls in which bucket. 23. Component creation via code editor
: actual implementation work has only truly begun last week. See the plan at š± [Meta] Plan for code components Active , which @balintbrews crafted. Pinged him to ask about must-have/should-have/nice-to-have breakdown, because that meta doesn't currently specify.2.1. Content editing of meta fields
needs clarification from @effulgentsia on whether it's essentially done by virtue of having thePage
content entity type plus a working6. Save (draft) content
. (I was on paternity leave and working limited capacity, I was in none of the meetings.)
At this time, there's nothing more I can do. Hopefully updates on the remaining pieces in the next 24 hours.
- Reconciling the should-haves for
- š«š®Finland lauriii Finland
Increasing the priority for following issues:
- š [Needs design] Library confusingly lists SDC-sourced and Block-sourced Components together Active (nice to have to must have)
- āØ Layers panel should not show Regions that are empty Active (nice to have to should have)
Added following issues to the list:
- š 'false' appears in Page Title when deleting all characters Active
- š Create back link in XB Active
- āØ Provide a way to create a new page Active
- āØ SEO settings for Pages Active
- āØ Open navigation modal by clicking on page title in XB navigation Postponed
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Increasing the priority for following issues:
You didn't actually ā you only added those new issues. Made it so!
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
I'm surprised š The pending changes API endpoint should list individual regions for global template changes Active isn't on here (for
6. Save (draft) content
).But AFAICT š Consider refactoring page_template into page_region(s) Active is now likely to be the successor to that, but it'd fall under
19. Modify the page template (i.e. global regions)
. Tentatively adding it to "should-have", but I have a hunch that even though unplanned, @lauriii would now in hindsight mark this as "must-have" ā so added it there. - š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Adding š Implement saving block settings forms Active .
- š«š®Finland lauriii Finland
Adding š Adding the Image component results in a state considered invalid Active since it's a critical bug.
- š¬š§United Kingdom jessebaker
Adding follow up issues from Global Regions MR
- š¬š§United Kingdom jessebaker
Added āØ Polish flow for Publish all changes" when receiving conflict errors in response Active to SHOULD-HAVE for 6. Save (draft) content
- Issue was unassigned.
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Lots has happened. Update some status emojis.
- šŗšøUnited States effulgentsia
Per #3497543-40: Milestone 0.2.0: the one for Drupal CMS 1.1 ā , we ended up not tagging a 0.2.0 release for inclusion in Drupal CMS. Therefore, this issue can go back to using that number.
We expect to tag the 0.2.0 release by the end of the week (which is also the end of the month), assuming we can wrap up these issues ā by then.
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
All š± [Meta] Plan for code components Active must-haves are done! š¤Æš„³
Plus, the long-standing š [Needs design] Library confusingly lists SDC-sourced and Block-sourced Components together Active finally landed too, which empowers a much nicer UX for landing
must-haves listed in this meta are done now, so marked each of the 7 requirements as ā .
- š«š®Finland lauriii Finland
Adding:
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Automatically closed - issue fixed for 2 weeks with no activity.
- šŗšøUnited States effulgentsia
I started writing up š± Milestone 1.0.0-beta1: Start creating non-throwaway sites Active . Note that that summary is very much a work in progress. Half the issues there probably don't really need to block a beta and possibly 80% of the stuff that we do want to get into the beta milestone isn't yet on that list. But hey, it's a start. Hopefully it will start resembling a proper roadmap within the next few weeks.