- Issue created by @wim leers
- Status changed to Postponed
7 months ago 4:27pm 19 June 2024 - š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
This builds on top of š± Milestone 0.1.0: Experience Builder Demo Active , so marking this . That doesn't mean we're not working on this already: work is already happening and being coordinated in š± [META] Early phase back-end work coordination Active ā with some of the issues in there being necessary for š± Milestone 0.1.0: Experience Builder Demo Active .
(If there wasn't a hard DrupalCon Barcelona deadline, š± Milestone 0.1.0: Experience Builder Demo Active and this milestone/issue would probably be one and the same.)
- Assigned to lauriii
- Status changed to Active
4 months ago 11:12am 18 September 2024 - š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
š± Milestone 0.1.0: Experience Builder Demo Active is nearly done. DrupalCon Barcelona 2024 is in a few days.
Time to get this fleshed out!
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Also: do we want to keep using š± [META] Early phase front-end work coordination Active + š± [META] Early phase back-end work coordination Active ?
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Some markup changes to improve clarity/scannability.
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Initial issue for product requirement
19. Modify the page template
created: š Introduce an XB `PageTemplate` config entity Active . - šŗšøUnited States Kristen Pol Santa Cruz, CA, USA
Let me know if you want/need anything in SDDS for this next milestone as well as for DrupalCon Singapore.
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Overhaul of the meta to reflect which of the 10 requirements are actionable, and to what extent. 9 of the 10 cannot begin UI+UX (aka client side) work due to designs not being ready.
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Updated the status for and .
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
š HTTP API to read+write PageTemplate and Pattern config entities Active landed!
For
2.1. Content editing of meta fields
, a new issue was identified as blocking the0.2
milestone: š [later phase] [RESEARCH] How to identify all meta fields for an arbitrary content entity? Active . - š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Finished adding š¢, š” or š“ to every ā®.
Also clarified why the two stretch goals are pretty firmly out of reach already at this stage.
- šŗšøUnited States effulgentsia
Removed the stretch goals from the list. We're not currently working on them so there's no realistic plan of them getting done by early January.
- šŗšøUnited States effulgentsia
Also descoped (with confirmation from @lauriii) revisions and Workspaces from 0.2.0.
- šŗšøUnited States effulgentsia
The Purpose and Expected result sections are incomplete. They don't capture the entirety of the remaining items that are in the Requirements section. When I find a bit of time, I'll fill in those sections so that they add clarity as to what the overarching goal of the 0.2.0 milestone is.
- šŗšøUnited States effulgentsia
Updated the proof-of-concept issue for the component code editor from š [exploratory] StackBlitz PoC Active to āØ [exploratory] PoC of Preact+Tailwind components editable via CodeMirror or Monaco Active .
- šŗšøUnited States effulgentsia
I updated the "Content editing of meta fields" section with 0.2.0 scope vs 0.3.0 scope.
- šŗšøUnited States effulgentsia
I'm retitling this issue from 0.2.0 to 0.3.0, and changing its target date from mid January to late February.
In the meantime, we'll release a 0.2.0 on or before Jan. 13, so that the Drupal CMS 1.0 release on Jan. 15 can reference a tagged release of XB. I'll open a separate issue for that; it won't include all of the scope of this one.
- šŗšøUnited States effulgentsia
Here's the one for 0.2.0: š± Milestone 0.2.0: the one for Drupal CMS 1.0 Active
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Updated the
19. Modify the page template
(i.e. global sections) requirement. It's working, but there's 3 currently known rough edges:- Assigned to: jessebaker š Empty global regions add unnecessary spacing to preview Active
- š If an autosave entry exists before enabling global regions for a theme, theme regions cannot be seen Active
- Assigned to: balintbrews āØ Focus mode for global regions Active , blocked on Assigned to: parthbcharya āØ Show page information in top bar Active
- šŗšøUnited States tedbow Ithaca, NY, USA
re "Save (draft) content:"
we already have
and a Publish button to trigger a real entity save:
but I guessing what we want for 0.3.0 is the "Publish all" and we will remove the individual entity save button.
@effulgentsia if that is correct I will add the issues that get use to "Publish all" to the summary
- šŗšøUnited States effulgentsia
what we want for 0.3.0 is the "Publish all" and we will remove the individual entity save button
Correct. I updated the corresponding text in the IS, but yeah, if you could update the corresponding issue list, that would help a lot, thanks!
- šŗšøUnited States effulgentsia
I updated the IS to change other occurrences of 0.2.0 in the summary to 0.3.0.
- šŗšøUnited States effulgentsia
With drupal.org's CSS, I'm finding the nested list hard to read. So I updated the IS to use
<h3>
headings for each high level capability instead. - š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
@effulgentsia Did you intentionally delete
?
- šŗšøUnited States effulgentsia
I did, because I thought it wasn't time yet to be tracking general "fix broken stuff" issues here yet. But I just now restored it under a new "Miscellaneous high priority fixes" heading.
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Updated the
29. Layout patterns
(i.e. sections) requirement.(And also updated
19. Modify the page template
's issue list ā lots of activity over there this week.) - š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
One more for
19. Modify the page template
, that was created a few hours ago! - š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Add anchors to facilitate deeplinking.
- šŗšøUnited States effulgentsia
Not wanting to take the time right now to figure out how to best organize these within the issue summary, but the following issues are still needed as part of "Place Blocks as Components":
- š [Needs design] Library confusingly lists SDC-sourced and Block-sourced Components together Active
- š Implement saving block settings forms Active
I wonder if we should turn each of the top-level requirements, such as "Place Blocks as Components", into their own Plan issue, so that we can make those the parent of individual issues like the above.
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
I wonder if we should turn each of the top-level requirements, such as "Place Blocks as Components", into their own Plan issue, so that we can make those the parent of the above issues and similar individual issues for the other top-level requirements.
-1 ā too much overhead and issue queue noise. I'd rather have a single issue with >200 updates than having to monitor half a dozen issues, each of which causes actual MR issues to be somewhat obscured.
Updated 5. Place blocks as components ā included everything @effulgentsia listed in #44 and expanded.
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
āØ [PP-1] Integrate saving sections with the backend Postponed just landed, which means
29. Layout patterns
is AFAICT the first requirement to be completely done! š„³ - šŗšøUnited States tedbow Ithaca, NY, USA
Added issue for the "Save (draft) content" section. I am still looking for more issues to add
- šŗšøUnited States effulgentsia
In addition to š [PP-1] Send page data to Drupal for storage in auto-save store Postponed: needs info being under the "Save (draft) content" requirement, it's also the last remaining item for "Content editing of meta fields", so landing it would give us another nice green checkmark in front of a top-level requirement.
š± [META] Pages Active is still listed in the IS under "Content editing of meta fields" but the remaining children of that are being tracked separately under that meta and don't need to block this issue.
- šŗšøUnited States tedbow Ithaca, NY, USA
Finished going through issue queue for 6. Save (draft) content section
I think we are close but we mind unknown issues once āØ [PP-1] Implement the "Publish All" button Postponed is completed as they will allow use to do the whole process. For this to include entity fields we will need the 2.1. Content editing of meta fields section to be done too
As far as know is š Some components cannot be used in XB because UI prevents SDC props being named `name` Active isn't required for 0.3.0
- šŗšøUnited States effulgentsia
As far as know is š Some components cannot be used in XB because UI prevents SDC props being named `name` Active isn't required for 0.3.0
Yeah, that issue and its children should be moved in the IS from the "save content" requirement to the "blocks" requirement. It's possible that the entirety of that isn't required for 0.3.0, but the parts that are blocking š Implement saving block settings forms Active are.
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Thanks, @tedbow! Updated that
6. Save (draft) section
section to follow the same structure as the others (BE/FE/E2E/Polish). Some were miscategorized. Some icons were off. But I kept the same set of issues.Thanks, that really helped!
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
And now adding + removing issues to that same section.
Added:
- š Save metadata(page data) field with the entity revision Active
- š Create an endpoint to publish all auto-saved entities Active
- š Create AutoSave service and HTTP API to retrieve all entities with pending changes Active
- āØ Save page data form values in application state with support for undo/redo Active
Removed (given my understanding of Lauri's original product requirements, but I was not in every meeting while working at limited capacity during paternity leave, so correct me if I'm wrong š):
- š [later phase] Support matching `{type: array, ā¦}` prop shapes Postponed ā we should absolutely do this and it is a stable blocker, but this was never intended to be solved as part of this
- š Add typed value-objects for the component tree structure Needs review ā definitely never intended to be solved as part of this
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Moved š [PP-2] Don't store page template model data in auto-save for an entity Postponed to for "Save (draft) content", and added a placeholder for the missing validation error support.
Also marked both "Save (draft) content" and "Modify the page template (i.e. global regions)" as š¢ ā but not yet ā : I have high confidence we'll be able to wrap those up given the current status + pace + outlook, but they're not yet done.
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Fixed formatting and added jumplinks.
- šŗšøUnited States tedbow Ithaca, NY, USA
@Wim Leers re #54 ok. yeah I reread the issue in š [PP-2] Don't store page template model data in auto-save for an entity Postponed . I missed this part
The values are filtered out in \Drupal\experience_builder\Controller\ClientServerConversionTrait::clientModelToServerProps but we are storing more in the autosave/tempstore than we need to.
I thought there would be conflict in "Publish All" phase because each entity could have its own copy of the global regions that could conflict. Now I see it is just extra data we don't actually use. So +1 on moving it to "Polish" section