Add typed value-objects for the component tree structure

Open on Drupal.org →

Created on 18 July 2024, 4 months ago

Updated 9 August 2024, 4 months ago

Overview

SdcController::layout() currently works with an array structure to model the tree structure.
In order to unlock other implementations of a tree structure, we need typed value objects.
This will make the tree structure better defined, and would unblock a Just-in-Time approach of loading e.g. Layout Builder into the Experience Builder UI, which in turn enables a smooth, gradual adoption/transition from Layout Builder to Experience Builder.

Proposed resolution

Add objects per https://git.drupalcode.org/project/experience_builder/-/merge_requests/68 (see ComponentLeaf(Interface) and friends)

User interface changes

📌 Task

Status

Needs work

Component

Data model

Created by

🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10

Live updates comments and jobs are added and updated live.

pnx²b

Sign in to follow issues

Merge Requests

!137Add typed value-objects for the component tree structure
Open
🇦🇺Australia larowlan
updated 3 days ago

Comments & Activities

Issue created by @larowlan
Comment 4 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
This should also allow refactoring 📌 Create validation constraint for ComponentTreeStructure Needs work to make it simpler 👍
Assigned to larowlan
Comment 4 months ago →
🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Brought in the value objects and a normalizer. Will continue tomorrow
Issue was unassigned.
Status changed to Needs review 4 months ago9:24pm 1 August 2024
Comment 4 months ago →
🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Merge request !137Draft: #3462235 - Value Objects for component tree 🌲 → (Open) created by larowlan
Assigned to wim leers
Comment 4 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Assigned to larowlan
Comment 4 months ago →
🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia
Wim Leers → credited kim.pepper → .
Comment 4 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Reviewed! (Review delayed due to 📌 Introduce an example set of representative SDC components; transition from "component list" to "component tree" Fixed , I explained this in my review on the MR.)
Comment 4 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Comment 4 months ago →
🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Thanks Wim, I'll pick this up again after vacation
Status changed to Needs work 4 months ago1:45pm 9 August 2024
Comment 4 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
👍 Enjoy! 😊

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024