- Issue created by @larowlan
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Methods such as those in
ClientServerConversionTrait
have logic around converting incoming request bodies into Typed data objects but also mix in some validation resultsAll of that is a stop-gap solution, the top priority should be resolving π Some components cannot be used in XB because UI prevents SDC props being named `name` Active , to evolve the client-side data model to support all known (current and ideally also future) needs.
@larowlan Do you agree with resolving that issue first? I've started the conversations for that in the week before my paternity leave, to set the stage, but it has unfortunately not been followed through. π
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Seems reasonable to me
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
The intent/scope of this issue has never been super clear to me.
Related discussion:
Wim, Dec 19, 2024:
π€ This is a client-side/UI model. It feels wrong/off to put this logic in a pure server-side representation? π
Wouldn't it be better to create a
ClientSideModel
typed object on the server side that can contain all the relevant transformation methods?Lee, Dec 19, 2024:
Yes, I've been wanting to do this for a long time - see https://www.drupal.org/project/experience_builder/issues/3489772 π Add a param converter and DTO for XB data model Active and !137
Very very keen.
On pure symfony API projects I have, we do this in request events so that controllers can type-hint the object and have zero logic of 'how do I take this request body and make something from it'. Realllllly keen to do that here. Thin controllers++
β https://git.drupalcode.org/project/experience_builder/-/merge_requests/4..., for π Implement auto-save of the page template config entity Active
That sounds amazing, so if that's the intent for this issue, then hell yes! ππ