- Issue created by @effulgentsia
- 🇮🇳India soaratul
What exact change we need to do in the UI for 👇?
When conflict IDs exist, these will be marked up differently in the pending changes UI - 🇺🇸United States effulgentsia
I'd say for the scope of this issue, just make their text color red. We can defer a better design to a followup issue after this one is done. Better to get this one in sooner than hold it up on figuring out that design.
- 🇮🇳India soaratul
I guess make text colour red for those that are not in the current list of redux store, but what about for the new items(I mean those are not in the redux store but are there in conflicts as additional item).
BTW it's very rare now we will get conflicts as clicking on Review N changes button now we are refetching pending changes also on every 10 seconds we are fetching.
- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
From a conversation in slack @soaratul noted there is no owner info in this
Blocker: Not sure how to proceed further? - let's discuss and decide.
{ "errors": [ { "code": 1, "detail": "This item is unexpected.", "source": { "pointer": "node:3:en" }, }, { "code": 2, "detail": "Expected item not present.", "source": { "pointer": "node:4:en" }, "meta": { "entity_type": "node", "entity_id": "4", "label": "Drupal node Article" } } ] }
I think what we need to do is include the auto-save key in meta so that you can match it against the records from the pending changes API
I'll open a separate issue for that
- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
- 🇺🇸United States effulgentsia
Up until now, the XB team has been following a pseudo-scrum/pseudo-kanban process, but we're now shifting into more conventional scrum. We started a new 2-week sprint last Thursday (Jan 16). I'm tagging our current sprint's issues for visibility.
- 🇬🇧United Kingdom jessebaker
Clicking publish all should publish changes. It currently doesn't, but it will at least show you an error as to why it can't publish.
There are follow ups
- As per @tedbow's suggestion in his review: polish handling for errors moved to follow up ✨ Polish flow for Publish all changes" when receiving conflict errors in response Active
- Publishing currently fails on nodes due to an error with the URL alias field 🐛 Unable to create URL aliases with XB enabled Active
- Changes show up immediately when previewing a node in XB 🐛 Once previewed in XB an entity with no changes will still show up in "Review x changes" Active
- The pending changes API endpoint should list individual regions for global template changes. Currently adding content to a node will show two changes - one for the node and another for the template[#3500390]
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
#14: is this hard-blocked on 🐛 Unable to create URL aliases with XB enabled Active ?
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
I did a review (and spotted a few nits) to try to answer #15 myself. AFAICT the answer is "yes".
If so, I propose to postpone this issue on 🐛 Unable to create URL aliases with XB enabled Active and I'll prioritize tackling that on Monday.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Well … that was easier than I thought! @longwave did the work, I did the research to prove his fix was correct: 🐛 Unable to create URL aliases with XB enabled Active is in!
-
hooroomoo →
committed 2b2f0e2e on 0.x authored by
soaratul →
Issue #3497530 by jessebaker, soaratul, effulgentsia, wim leers,...
-
hooroomoo →
committed 2b2f0e2e on 0.x authored by
soaratul →
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
🤩
But can we get a short screencast to share this with the world? 🫣🙏
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Not pragmatic to await this screenshot anymore, so marking fixed. This'll have to be demonstrated as part of other issues landing, then.
- Status changed to Fixed
about 1 month ago 9:09am 18 March 2025 Automatically closed - issue fixed for 2 weeks with no activity.