- Issue created by @larowlan
- 🇺🇸United States effulgentsia
I updated this issue's title and description to reflect a smaller scope: just the "Review N changes" button and what it shows when you click it. I opened ✨ [PP-1] Implement the "Publish All" button Postponed for the "Publish All" button.
- 🇺🇸United States effulgentsia
It looks to me like there are still some unresolved comments on the MR, so setting to "Needs work".
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
I'd like to get a short screencast or a GIF in place to demonstrate this, because a static screenshot makes it hard to get a sense of the impact. 🙏
The (static) screenshots do look interesting already though! 😄
(Also a few high-level questions. Also: random failures on PostgreSQL CI runs, re-queued those 👍)
- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
There's one remaining thread here that I think can be resolved by just removing that piece of code, it seems to work fine without it.
- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
@effulgentsia asked me to make that change and merge this so that @soaratul can continue with ✨ [PP-1] Implement the "Publish All" button Postponed
-
larowlan →
committed ed9d69d4 on 0.x authored by
soaratul →
Issue #3491459 by soaratul, larowlan, effulgentsia, lauriii, hooroomoo,...
-
larowlan →
committed ed9d69d4 on 0.x authored by
soaratul →
- 🇫🇮Finland lauriii Finland
We might need some follow-ups for this if these don't already exist:
- The change icons are not using the correct colors. Based on https://www.figma.com/design/Ps3m4APGHIILsBrm0Uj31N/Experience-Builder?n..., components are supposed to be purple and global regions are supposed to be green.
- For some reason, a page shows up categorized as a component. It should be categorized as a page.
- Instead of showing "Olivero global template" has been changed, the review panel should show which regions have been changed: https://www.figma.com/design/Ps3m4APGHIILsBrm0Uj31N/Experience-Builder?n...
- The current color behavior doesn't seem to result in a consistent color for a user. A single user should have the same color displayed for them to make it easy to identify changes made by one user.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Rather than creating follow-ups, let's just do another MR in this issue: to get the scope of this issue solved here.
- 🇬🇧United Kingdom jessebaker
Using the same numbers as #22
- The Figma isn't immediately clear. Is it correct that the categorization is as follows
- Pages - grey, page icon (Although home page is show with a House icon)
- Global Regions - green, cube icon (Figma also shows the diagonal 3 square icon in some places and refers to them as Global Sections)
- Components - purple, diagonal 4 square icon
- Elements - grey, various icons (we don't have a concept of elements yet)
- Should be a simple fix. I think the code currently falls back to the component icon for types it doesn't know and does not have a case for 'node'.
- I believe this will need a change to the data the endpoint returns - perhaps better suited to a follow up issue.
- This poses many questions. Where does the colour come from? Can users choose a colour? Is the colour stored somewhere or should it be randomly generated on page load? Should the colour come back as a property of the user and be determined on back end? What are the available colour options? Again, maybe a follow up for this.
- The Figma isn't immediately clear. Is it correct that the categorization is as follows
- 🇫🇮Finland lauriii Finland
The Figma isn't immediately clear. Is it correct that the categorization is as follows
Correct 👍
Should be a simple fix. I think the code currently falls back to the component icon for types it doesn't know and does not have a case for 'node'.
Ah you're right that this is actually a node and it should use the CMS icon. I think we should also come up with a better fallback icon.
I believe this will need a change to the data the endpoint returns - perhaps better suited to a follow up issue.
+1 for a follow-up.
This poses many questions. Where does the colour come from? Can users choose a colour? Is the colour stored somewhere or should it be randomly generated on page load? Should the colour come back as a property of the user and be determined on back end? What are the available colour options? Again, maybe a follow up for this.
Sounds like something we should probably figure out in a follow-up.
- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Opened 📌 The pending changes API endpoint should list individual regions for global template changes Active for follow-up
- 🇺🇸United States effulgentsia
Up until now, the XB team has been following a pseudo-scrum/pseudo-kanban process, but we're now shifting into more conventional scrum. We started a new 2-week sprint last Thursday (Jan 16). I'm tagging our current sprint's issues for visibility.
- 🇬🇧United Kingdom longwave UK
Opened 📌 Decide how to assign colours to users for "review changes" Active for #22.4 / #24.4.
I think we could finish off #22.1 and #22.2 in this issue.
- 🇬🇧United Kingdom longwave UK
MR!577 implements #24.1/#24.2 and the comment in #25.
- Pages have a grey page icon.
- Global regions have a green cube icon.
- Nodes (CMS content) have a grey cylinder icon.
The last one wasn't available in Radix so I exported the SVG from Figma and added
vite-plugin-svgr
to be able to use SVGs as React components - looks like this is the first time we have needed to do this. - 🇬🇧United Kingdom longwave UK
longwave → changed the visibility of the branch 3491459-create-api-slice-for-pending-changes to hidden.
-
jessebaker →
committed 800b9b24 on 0.x authored by
longwave →
Issue #3491459 by soaratul, larowlan, longwave, lauriii, effulgentsia,...
-
jessebaker →
committed 800b9b24 on 0.x authored by
longwave →
- 🇬🇧United Kingdom jessebaker
I've approved and merged !577 which resolves #24.1 and #24.2
Closing this issue. There are two follow ups for #24.3 and #24.4
📌 The pending changes API endpoint should list individual regions for global template changes Active and
📌 Decide how to assign colours to users for "review changes" Active - Status changed to Fixed
about 2 months ago 4:49am 14 February 2025 Automatically closed - issue fixed for 2 weeks with no activity.