SEO settings for Pages

Reviewed. I have maintainability concerns about the current code, and I have a strong hunch that this doesn't actually work 😅

P.S.: can we get 🌱 [META] Pages Active updated? 🙏

Per @amangrover90's MR comments (thanks!), this needs review from https://www.drupal.org/project/issues/experience_builder?component=Redux... → owner @bnjmnm.

Left comments on the MR bits relevant to me

Shouldn't a metatag integration of sorts be used for this? 😰

Shouldn't a metatag integration of sorts be used for this? 😰

This is implemented as an integration to metatag. However, the metatag module is everything but the kitchen sink so it's usually not used just as it is. It is common to set up content types with fields for the commonly set meta tags and they are placed using tokens in the specific metatags. That's what we are doing for the Page entity type too. 😊

Tested the MR manually with metatag module installed and uninstalled and it seems to be working as expected in both cases 👍

I spoke too soon in #12. I generated some more pages and realized that in this case the token is visible in the field:

I think we should implement one of two possible options because the tokens are not something we expect a content person to use or understand in most cases:

1. Keep the field empty and do not show the token value here (only override if value is provided)
2. Automatically generate the value as a preview of what it currently would be instead of showing the token. This should be updated in real time as the page title is being changed.

Can #13 be a follow up? Options 1 & 2 aren't that easy. If we leave it empty, Metatag will assume the override is empty. In \Drupal\metatag\Plugin\Field\FieldType\MetatagFieldItem::preSave it compares the field values against the defaults to determine overrides. It will be considered empty.

2 requires more work.

It's a UX improvement to normal Drupal-flow with tokens. Can that be reasoning enough to make a follow up, with this ticket exposing the UI and the follow up being adjusting default Drupal token UX

If it's difficult to address, let's move it to a follow-up so that we can proceed here.

I discussed with @amangrover90 and it is brushing on the edge of "can be difficult" and adjusting the scope of this issue.

Created 📌 Followup: tokens for page title in SEO settings Postponed as the follow up. Tests were added.

Retitling per https://git.drupalcode.org/project/experience_builder/-/merge_requests/5... — because I previously pointed out that everything in this issue suggests it should be saveable. But apparently that's for a follow-up.

Updated issue summary to make it clear that the scope was narrowed.

wim leers → changed the visibility of the branch 3497000-seo-settings-for to hidden.

After some fighting with GitLab to get this to merge, I won! 😜

Thanks, @amangrover90 & @mglaman!

Automatically closed - issue fixed for 2 weeks with no activity.