[PP-2] Don't store page template model data in auto-save for an entity

Open on Drupal.org →

Created on 23 December 2024, 4 months ago

Overview

Blocked on 📌 Add a param converter and DTO for XB data model Active and 📌 Implement saving block settings forms Active

In 📌 Implement saving block settings forms Active we're storing autosaves for global regions but this means that each entity's autosave entry can include model entries for the global regions. The values are filtered out in \Drupal\experience_builder\Controller\ClientServerConversionTrait::clientModelToServerProps but we are storing more in the autosave/tempstore than we need to.

Proposed resolution

Wait for 📌 Add a param converter and DTO for XB data model Active and 📌 Implement saving block settings forms Active
Add methods to the client model value objects to filter out values from the model that don't apply to the content region

User interface changes

📌 Task

Status

Postponed

Version

0.0

Component

Data model

Created by

🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @larowlan
Comment 4 months ago →
🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Comment 3 months ago →
🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Comment 3 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Tangentially related: ✨ Integrate saving page templates with the backend: (de)normalize PageTemplate config entities using the client-side data model Active . Even after this, you don't expect to directly read/write a PageTemplate config entity, right, @larowlan?
Comment 3 months ago →
🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Agree
Comment 3 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Per #3501600-4: Consider refactoring page_template into page_region(s) → , if we go that route, AFAICT this'd become obsolete.
Comment 3 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Per @longwave: I misread & misunderstood! Undoing #6.
Comment 3 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Comment about 1 month ago →
🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Related issue 🐛 Once previewed in XB an entity with no changes will still show up in "Review x changes" Active will mean this is closed (duplicate)
Comment about 1 month ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
AFAICT 📌 Consider refactoring page_template into page_region(s) Active already made this obsolete. 😄

Either way: closing!
Comment about 1 month ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Aha, this is what @larowlan was referring to: https://git.drupalcode.org/project/experience_builder/-/merge_requests/7... 😊

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024